added the function name to message in a couple of rules#14
Open
parsiya wants to merge 1 commit into0xdea:mainfrom
Open
added the function name to message in a couple of rules#14parsiya wants to merge 1 commit into0xdea:mainfrom
parsiya wants to merge 1 commit into0xdea:mainfrom
Conversation
Owner
|
Thank you for the PR! It's a nice idea and I didn't know that it was possible with Semgrep. I have to check how this change impacts SARIF Explorer and similar tools to make sure it doesn't break them. I'll get back to you after the holidays, during which I'll finally be AFK for some time. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought having the function name in the message will help with triage either manually or using the message as a filter.
If this is something you want to incorporate, the decision is how you want the message to look like (e.g., where does the function name appear in the message). I am open to the location so it's clearer to users.
If this useful, I can go ahead and work on some of the other rules that have a similar structure.