Add maxParallelProofs option to NativeProver#405
Open
volodymyr-basiuk wants to merge 3 commits intomainfrom
Open
Add maxParallelProofs option to NativeProver#405volodymyr-basiuk wants to merge 3 commits intomainfrom
volodymyr-basiuk wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configurable concurrency cap for proof generation in the default NativeProver, plumbed through ProofService options so consumers (and tests) can limit parallel proof creation.
Changes:
- Introduces
ProverOptions.maxParallelProofsand a queue-based concurrency limiter aroundNativeProver.generate(). - Extends
ProofServiceOptionswithproverOptionsand passes them when constructing the defaultNativeProver. - Updates an auth handler test to set
maxParallelProofs: 1and bumps package version to1.43.1.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/handlers/auth.test.ts | Uses ProofService constructor options to set proverOptions.maxParallelProofs. |
| src/proof/provers/prover.ts | Adds ProverOptions and implements concurrency limiting for NativeProver.generate(). |
| src/proof/proof-service.ts | Adds proverOptions to ProofServiceOptions and wires it into default prover construction. |
| package.json | Patch version bump to 1.43.1. |
| package-lock.json | Lockfile version bump to 1.43.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+149
to
+151
| if (this._activeProofs < (this._maxParallelProofs as number)) { | ||
| this._activeProofs++; | ||
| return; |
Comment on lines
+162
to
+167
| private releaseSlot(): void { | ||
| this._activeProofs--; | ||
| const next = this._queue.shift(); | ||
| if (next) { | ||
| next(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
queue won't be big in this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.