Conversation
Signed-off-by: Dave Grantham <dgrantham@polygon.technology>
|
Here's the error and logging refactor. I haven't been able to set up a proper testing environment yet or try against the staging network/datadog. Let's get that done ASAP so I can see what kind of errors and logging comes out of this. It looks good in my head but it might be a different story in production. |
MaximusHaximus
left a comment
MaximusHaximus
left a comment
There was a problem hiding this comment.
Just had one question about consistency in returning structured errors in responses to clients -- as long as DD is handling the error output as expected this LGTM shipping-wise 👍
| ) | ||
| .into_response(), | ||
| // Chain errors and internal errors return structured error responses | ||
| ref err @ FacilitatorLocalError::Evm(_) |
There was a problem hiding this comment.
🤔 hmm -- I'm curious why only this subset of errors are being transformed into structured errors -- shouldn't all errors be returned as structured responses if we're going to introduce them to the system?
2 participants
This refactors errors and logging
Signed-off-by: Dave Grantham dgrantham@polygon.technology