Skip to content

chore: Update linting (eslint v10 / @polygonlabs/apps-team-lint v1.0.0)#61

Merged
AkshatGada merged 1 commit intomainfrom
chore/migrate-to-apps-team-lint-v1
Mar 20, 2026
Merged

chore: Update linting (eslint v10 / @polygonlabs/apps-team-lint v1.0.0)#61
AkshatGada merged 1 commit intomainfrom
chore/migrate-to-apps-team-lint-v1

Conversation

@MaximusHaximus
Copy link
Contributor

@MaximusHaximus MaximusHaximus commented Mar 19, 2026

Summary

No behavioural changes; just repository tooling updates.

  • Upgrades ESLint from v9 to v10 - eslint v10 simplifies composition of flat eslint configuration in a pnpm monorepo significantly
  • Replaces the removed javascript() export with recommended({ globals: 'node' })
  • Adds defineConfig wrapper to all ESLint configs
  • Splits root monolith eslint.config.js into per-package configs
    (packages/polygon-agent-cli/ and packages/connector-ui/) per ESLint v10
    per-file config discovery, with the root becoming a thin safety net
  • Adds TypeScript project references in root tsconfig.json for correct
    monorepo TS resolution with projectService: true
  • Adds lint script to each package for running ESLint directly in each package
  • Simplifies root lint script to eslint .
  • Adds trustPolicyExclude: ['semver@5.7.2 || 6.3.1'] to pnpm-workspace.yaml
    — these are false positives from pnpm's no-downgrade trust policy comparing
    provenance across major versions; tracked in pnpm/pnpm#10202

Test plan

  • pnpm install completes without errors
  • pnpm run lint passes (0 errors)
  • pnpm run build succeeds for both packages
  • pnpm run typecheck passes for both packages

- Upgrade eslint peer dep from v9 to v10
- Replace removed javascript() with recommended({ globals: 'node' })
- Add defineConfig wrapper and per-package eslint.config.js files
- Add tsconfig.json project references for monorepo TS resolution
- Add trustPolicyExclude for semver@5.7.2 || 6.3.1 (false positives
  from cross-major provenance comparison, tracked in pnpm/pnpm#10202)
@MaximusHaximus MaximusHaximus marked this pull request as ready for review March 19, 2026 19:43
@MaximusHaximus MaximusHaximus changed the title chore: migrate to @polygonlabs/apps-team-lint v1.0.0 chore: Update linting (eslint v10 / @polygonlabs/apps-team-lint v1.0.0) Mar 19, 2026
Copy link
Collaborator

@AkshatGada AkshatGada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@AkshatGada AkshatGada merged commit 0559ac8 into main Mar 20, 2026
4 checks passed
@AkshatGada AkshatGada deleted the chore/migrate-to-apps-team-lint-v1 branch March 20, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants