Conversation
|
ZeroEkkusu
approved these changes
Sep 8, 2025
web3security
approved these changes
Sep 11, 2025
web3security
left a comment
web3security
left a comment
There was a problem hiding this comment.
LGTM thanks for doing it.
The only comment is that I'd suggest we try to have independent PR's for each change management, for example having 1 for the emission change different from the migrateTo as we are mixing several things within the same PR this time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two contracts were upgraded:
EmissionManager 1.4.0
https://etherscan.io/address/0xbC9f74b3b14f460a6c47dCdDFd17411cBc7b6c53#readProxyContract#F12
PolygonMigration 1.2.0
https://etherscan.io/address/0x29e7df7b6a1b2b07b731457f499e1696c60e2c4e#readProxyContract#F6