Fix storing "en" twice as language for profanity #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If text being scanned for profanity couldn't be associated with complete certainty to a single language, we add English as fallback language to the list of detected languages. However, if the detected language was English as well, we did end up with storing "en" twice for the detected languages. This commit fixes that, so "en" is only stored once. While using a set for removing duplicates would've been the most natural solution, we can't use that, as we need to preserve the order of languages. Therefore dict.fromkeys() is used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If text being scanned for profanity couldn't be associated with complete certainty to a single language, we add English as fallback language to the list of detected languages. However, if the detected language was English as well, we did end up with storing "en" twice for the detected languages. This commit fixes that, so "en" is only stored once. While using a set for removing duplicates would've been the most natural solution, we can't use that, as we need to preserve the order of languages. Therefore dict.fromkeys() is used instead.