This repository was archived by the owner on Jan 27, 2025. It is now read-only.
[Chore] Remove/refactor .clone() from the /ol/types folder where needed#1258
Open
shawnharmsen wants to merge 1 commit into0LNetworkCommunity:v6from
Open
[Chore] Remove/refactor .clone() from the /ol/types folder where needed#1258shawnharmsen wants to merge 1 commit into0LNetworkCommunity:v6from
shawnharmsen wants to merge 1 commit into0LNetworkCommunity:v6from
Conversation
Author
|
val_config_ip_address test fails on v6 branch as well as here ➜ types git:(v6) cargo test
Finished test [unoptimized + debuginfo] target(s) in 0.55s
Running unittests (/Users/term/Desktop/my-github/libra/target/debug/deps/ol_types-3fb17c86fafb9dfe)
running 12 tests
test epoch_timer::test_changeset ... ok
test fixtures::test_block ... ok
test account::test_parse_account_file ... ok
test pay_instruction::parse_file ... ok
test pay_instruction::parse_fixed_recurr_type ... ok
test pay_instruction::parse_pct_balance_end_epoch_type ... ok
test pay_instruction::parse_fixed_recurr_end_epoch_type ... ok
test pay_instruction::parse_pct_change_end_epoch_type ... ok
test pay_instruction::parse_pct_balance_type ... ok
test pay_instruction::parse_pct_change_type ... ok
test pay_instruction::parse_fixed_once_type ... ok
test account::val_config_ip_address ... FAILED
failures:
---- account::val_config_ip_address stdout ----
thread 'account::val_config_ip_address' panicked at 'assertion failed: `(left == right)`
left: `"012d0400a1230da9052218072029fa0229ff55e1307caf3e32f3f4d0f2cb322cbb5e6d264c1df92e7740e1c06f0800"`,
right: `"012d0400a1230da90522180720893cc3f3b7f5bc55eb73e2e668520533fbe3938c4658ee70893f69e5944b76160800"`', ol/types/src/account.rs:327:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
account::val_config_ip_address
test result: FAILED. 11 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s
error: test failed, to rerun pass '--lib' |
0xzoz
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1204
rustfmtandclippyfor formatting and linting