Add Character Figure art - #76
Open
050644zf wants to merge 8 commits into
Open
Conversation
|
也许需要考虑移动端的适配？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a test branch resolve #40 is released, contributor can checkout this branch and make contribution on it.
By hovering the name you can view the art, if there aren't art it won't pop up
Issue to be resolved before merge:
Thanks to @M1hono we have found a more complete source for those art. But I found the file structure is differ between some chars. For most of char the img is located by
charId/artId.png, however the arts from some chars like doctor aren't put in the folder which result in 404. This issue was addressed in Unreliable folder structures ArknightsAssets/ArknightsAssets#1 .The code to get the figure art id is located in ASTR-Script/jsonconvert.py. These code track the
character/charslotproperty to define what art is being used in the following lines. Currently the firgure art looks correctly tracked in most of lines, but idk if there are incorrect lines exist. Need further investigation.Come up a better idea to show the figure art.