Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit 5f39514

Browse files
committed
update NOTE
Signed-off-by: William Woodruff <[email protected]>
1 parent e55c621 commit 5f39514

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/common.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,8 @@ impl FromStr for RepositoryUses {
236236
// In theory we could do `From<String>` instead, but
237237
// `&mut str::split_mut` and similar don't exist yet.
238238

239-
// NOTE: Technically both git refs and action paths can contain `@`,
240-
// so this isn't guaranteed to be correct. In practice, however,
241-
// splitting on the last `@` is mostly reliable.
239+
// NOTE: Both git refs and paths can contain `@`, but in practice
240+
// GHA refuses to run a `uses:` clause with more than one `@` in it.
242241
let (path, git_ref) = match uses.rsplit_once('@') {
243242
Some((path, git_ref)) => (path, Some(git_ref)),
244243
None => (uses, None),

0 commit comments

Comments
 (0)