Skip to content

Commit 02fbdd8

Browse files
committed
bugfix: logger is nil
1 parent 4f62094 commit 02fbdd8

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

clickhouse.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package clickhousebuffer
33
import (
44
"context"
55
"fmt"
6+
"log"
67
"net/url"
78
"strings"
89
"time"
@@ -31,7 +32,6 @@ type View struct {
3132
type ClickhouseImpl struct {
3233
db *sqlx.DB
3334
insertTimeout uint
34-
logger Logger
3535
}
3636

3737
type ClickhouseCfg struct {
@@ -108,13 +108,13 @@ func (ci *ClickhouseImpl) Insert(ctx context.Context, view View, rows []buffer.R
108108
// If you do not call the rollback function there will be a memory leak and goroutine
109109
// Such a leak can occur if there is no access to the table or there is no table itself
110110
if err := tx.Rollback(); err != nil {
111-
ci.logger.Log(err)
111+
log.Println(err)
112112
}
113113
return 0, err
114114
}
115115
defer func() {
116116
if err := stmt.Close(); err != nil {
117-
ci.logger.Log(err)
117+
log.Println(err)
118118
}
119119
}()
120120

@@ -127,7 +127,7 @@ func (ci *ClickhouseImpl) Insert(ctx context.Context, view View, rows []buffer.R
127127
if _, err := stmt.ExecContext(timeoutContext, row...); err == nil {
128128
affected++
129129
} else {
130-
ci.logger.Log(err)
130+
log.Println(err)
131131
}
132132
}
133133
if err := tx.Commit(); err != nil {

write.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package clickhousebuffer
22

33
import (
4-
"fmt"
54
"log"
65
"time"
76

@@ -110,7 +109,7 @@ func (w *WriterImpl) Close() {
110109
}
111110
}
112111
if w.writeOptions.isDebug {
113-
log.Println(fmt.Sprintf("close writer %s", w.view.Name))
112+
log.Printf("close writer %s", w.view.Name)
114113
}
115114
}
116115

0 commit comments

Comments
 (0)