ensure generator is only traversed once

Guite · Guite · commit d87a1d281fef · 2025-09-15T19:43:26.000+02:00
diff --git a/src/system/ThemeBundle/src/ExtensionMenu/ExtensionMenuCollector.php b/src/system/ThemeBundle/src/ExtensionMenu/ExtensionMenuCollector.php
@@ -58,8 +58,8 @@ public function getAllByContext(string $context = ExtensionMenuInterface::CONTEX
     {
         $menus = [];
         foreach ($this->extensionMenus as $bundleName => $extensionMenu) {
-            $menu = $extensionMenu->get($context);
-            if (0 < count(iterator_to_array($menu))) {
+            $menu = iterator_to_array($extensionMenu->get($context));
+            if (0 < count($menu)) {
                 $menus[$bundleName] = $menu;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,8 @@ public function getAllByContext(string $context = ExtensionMenuInterface::CONTEX`
`58`	`58`	`{`
`59`	`59`	`$menus = [];`
`60`	`60`	`foreach ($this->extensionMenus as $bundleName => $extensionMenu) {`
`61`		`- $menu = $extensionMenu->get($context);`
`62`		`- if (0 < count(iterator_to_array($menu))) {`
	`61`	`+ $menu = iterator_to_array($extensionMenu->get($context));`
	`62`	`+ if (0 < count($menu)) {`
`63`	`63`	`$menus[$bundleName] = $menu;`
`64`	`64`	`}`
`65`	`65`	`}`