ZfModule\Mapper\Module::findByOwner should not ignore $owner parameter

adamlundrigan · adamlundrigan · commit 8b6e4a647e1a · 2015-02-03T21:45:17.000-03:30
diff --git a/module/ZfModule/src/ZfModule/Mapper/Module.php b/module/ZfModule/src/ZfModule/Mapper/Module.php
@@ -87,12 +87,12 @@ public function findByLike($query, $limit = null, $orderBy = null, $sort = 'ASC'
         return $entity;
     }
 
-    /**
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
-     */
     public function findByOwner($owner, $limit = null, $orderBy = null, $sort = 'ASC')
     {
         $select = $this->getSelect();
+        if ($owner) {
+            $select->where(['owner' => $owner]);
+        }
 
         if ($orderBy) {
             $select->order($orderBy . ' ' . $sort);

Original file line number	Diff line number	Diff line change
`@@ -87,12 +87,12 @@ public function findByLike($query, $limit = null, $orderBy = null, $sort = 'ASC'`
`87`	`87`	`return $entity;`
`88`	`88`	`}`
`89`	`89`
`90`		`- /**`
`91`		`- * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`92`		`- */`
`93`	`90`	`public function findByOwner($owner, $limit = null, $orderBy = null, $sort = 'ASC')`
`94`	`91`	`{`
`95`	`92`	`$select = $this->getSelect();`
	`93`	`+ if ($owner) {`
	`94`	`+ $select->where(['owner' => $owner]);`
	`95`	`+ }`
`96`	`96`
`97`	`97`	`if ($orderBy) {`
`98`	`98`	`$select->order($orderBy . ' ' . $sort);`