detect_venv should not use shell for activation

[WeetHet]

This is horrible

zed/crates/project/src/terminals.rs

Lines 133 to 223 in 11fb57a

	let activation_script = maybe!(async {
	let toolchain = toolchain?.await?;
	Some(
	lang_registry
	.language_for_name(&toolchain.language_name.0)
	.await
	.ok()?
	.toolchain_lister()?
	.activation_script(&toolchain, ShellKind::new(&shell), fs.as_ref())
	.await,
	)
	})
	.await
	.unwrap_or_default();
	project.update(cx, move |this, cx| {
	let shell = {
	env.extend(spawn_task.env);
	match remote_client {
	Some(remote_client) => match activation_script.clone() {
	activation_script if !activation_script.is_empty() => {
	let activation_script = activation_script.join("; ");
	let to_run = if let Some(command) = spawn_task.command {
	let command: Option<Cow<str>> = shlex::try_quote(&command).ok();
	let args = spawn_task
	.args
	.iter()
	.filter_map(|arg| shlex::try_quote(arg).ok());
	command.into_iter().chain(args).join(" ")
	} else {
	format!("exec {shell} -l")
	};
	let args = vec![
	"-c".to_owned(),
	format!("{activation_script}; {to_run}",),
	];
	create_remote_shell(
	Some((&shell, &args)),
	&mut env,
	path,
	remote_client,
	cx,
	)?
	}
	_ => create_remote_shell(
	spawn_task
	.command
	.as_ref()
	.map(|command| (command, &spawn_task.args)),
	&mut env,
	path,
	remote_client,
	cx,
	)?,
	},
	None => match activation_script.clone() {
	activation_script if !activation_script.is_empty() => {
	let activation_script = activation_script.join("; ");
	let to_run = if let Some(command) = spawn_task.command {
	let command: Option<Cow<str>> = shlex::try_quote(&command).ok();
	let args = spawn_task
	.args
	.iter()
	.filter_map(|arg| shlex::try_quote(arg).ok());
	command.into_iter().chain(args).join(" ")
	} else {
	format!("exec {shell} -l")
	};
	Shell::WithArguments {
	program: shell,
	args: vec![
	"-c".to_owned(),
	format!("{activation_script}; {to_run}",),
	],
	title_override: None,
	}
	}
	_ => {
	if let Some(program) = spawn_task.command {
	Shell::WithArguments {
	program,
	args: spawn_task.args,
	title_override: None,
	}
	} else {
	Shell::System
	}
	}
	},
	}
	};

We can just set the env ourselves either the same way it's done for direnv with shell_hook (spawn a shell, get the environment after) or just update PATH and VIRTUAL_ENV manually when starting terminal

Both the current and the first approach aren't portable so I vote for the second approach. It will still need to be adjusted for windows having /Scripts and not /bin but at least it would work since I haven't been able to successfully make automatic venv activation on windows work myself

[WeetHet]

cc @SomeoneToIgnore

[SomeoneToIgnore]

I do not deal with Python and badly out of the context.

[osiewicz]

Can you elaborate on why it is horrible? IMHO using an activation script is kinda neat in that we're not making assumptions about the contents of that activation - thus, it works as if you opened the terminal and ran the script itself.

cc @Veykril

[WeetHet]

We need to work with a cartesian product of shells x operating systems vs just having some code for each different operating system. At least we need to provide such fallback for people with different shells and also for Windows since right now it doesn't work there (at least with powershell)