Skip to content

Commit 1d86ee5

Browse files
author
Andrei Kamarouski
committed
feature: do not register driver failure
1 parent ee4762e commit 1d86ee5

File tree

4 files changed

+21
-1
lines changed

4 files changed

+21
-1
lines changed

src/main/java/com/zebrunner/agent/core/config/ConfigurationHolder.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,11 @@ public static boolean shouldSubstituteRemoteWebDrivers() {
8080
return substituteRemoteWebDrivers != null && substituteRemoteWebDrivers;
8181
}
8282

83+
public static boolean silentDriverFailure() {
84+
Boolean silentDriverFailure = configuration.getRun().getSilentDriverFailure();
85+
return silentDriverFailure != null && silentDriverFailure;
86+
}
87+
8388
public static boolean shouldTreatSkipsAsFailures() {
8489
Boolean treatSkipsAsFailures = configuration.getRun().getTreatSkipsAsFailures();
8590
return treatSkipsAsFailures == null || treatSkipsAsFailures;

src/main/java/com/zebrunner/agent/core/config/ConfigurationProvidersChain.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,10 @@ private static void merge(ReportingConfiguration config, ReportingConfiguration
320320
run.setTreatSkipsAsFailures(providedConfig.getRun().getTreatSkipsAsFailures());
321321
}
322322

323+
if(run.getSilentDriverFailure() == null) {
324+
run.setSilentDriverFailure(providedConfig.getRun().getSilentDriverFailure());
325+
}
326+
323327
ReportingConfiguration.NotificationConfiguration notification = config.getNotification();
324328
if (notification.getEnabled() == null) {
325329
notification.setEnabled(providedConfig.getNotification().getEnabled());

src/main/java/com/zebrunner/agent/core/config/ReportingConfiguration.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,12 @@ public static class RunConfiguration {
128128
@EnvironmentVariable("REPORTING_RUN_SUBSTITUTE_REMOTE_WEB_DRIVERS")
129129
private Boolean substituteRemoteWebDrivers;
130130

131+
@YamlProperty("reporting.run.silent-driver-failure")
132+
@EnvironmentVariable("REPORTING_RUN_SILENT_DRIVER_FAILURE")
133+
@PropertiesFileProperty("reporting.run.silent-driver-failure")
134+
@SystemProperty({"reporting.run.silent-driver-failure"})
135+
private Boolean silentDriverFailure;
136+
131137
@YamlProperty("reporting.run.treat-skips-as-failures")
132138
@SystemProperty("reporting.run.treat-skips-as-failures")
133139
@EnvironmentVariable("REPORTING_RUN_TREAT_SKIPS_AS_FAILURES")

src/main/java/com/zebrunner/agent/core/webdriver/StartSessionInterceptor.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.zebrunner.agent.core.config.ConfigurationHolder;
44
import com.zebrunner.agent.core.registrar.TestSessionRegistrar;
55
import com.zebrunner.agent.core.registrar.descriptor.SessionStartDescriptor;
6+
import com.zebrunner.agent.core.registrar.domain.TestSessionDTO;
67
import lombok.extern.slf4j.Slf4j;
78
import net.bytebuddy.implementation.bind.annotation.Argument;
89
import net.bytebuddy.implementation.bind.annotation.RuntimeType;
@@ -68,7 +69,11 @@ public static void onSessionStart(@This RemoteWebDriver driver,
6869
startDescriptor.failedToStart(errorMessageStringWriter.toString());
6970
throw e;
7071
} finally {
71-
REGISTRAR.registerStart(startDescriptor);
72+
if(!ConfigurationHolder.silentDriverFailure() ||
73+
(ConfigurationHolder.silentDriverFailure() &&
74+
TestSessionDTO.Status.RUNNING.equals(startDescriptor.getStatus()))) {
75+
REGISTRAR.registerStart(startDescriptor);
76+
}
7277
}
7378
}
7479

0 commit comments

Comments
 (0)