-
Notifications
You must be signed in to change notification settings - Fork 51
Feat: add top-level open_virtual_datatree #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maxrjones
wants to merge
9
commits into
zarr-developers:main
Choose a base branch
from
maxrjones:open-virtual-datatree
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 113c712 Author: Ilan Gold <[email protected]> Date: Tue Nov 11 17:25:49 2025 +0100 Update virtualizarr/tests/test_parsers/test_hdf/test_hdf.py Co-authored-by: Chuck Daniels <[email protected]> commit 5693649 Author: Ilan Gold <[email protected]> Date: Tue Nov 11 17:25:10 2025 +0100 refactor: `get_deepest_group_or_array` type commit 849d567 Merge: 916c3e1 7a13261 Author: Ilan Gold <[email protected]> Date: Fri Nov 7 14:18:51 2025 +0100 Merge branch 'main' into ig/nested_h5_group commit 916c3e1 Merge: d8dc369 a2b65c1 Author: Ilan Gold <[email protected]> Date: Wed Sep 10 13:11:01 2025 +0200 Merge branch 'main' into ig/nested_h5_group commit d8dc369 Author: Ilan Gold <[email protected]> Date: Sun Sep 7 19:53:08 2025 +0200 fix: update release note commit a3a2615 Author: ilan-gold <[email protected]> Date: Sun Sep 7 16:45:22 2025 +0200 chore: clean up error handling for non-metadata group requests + tests commit fc0e999 Merge: 3036de8 1facb10 Author: ilan-gold <[email protected]> Date: Sun Sep 7 16:29:59 2025 +0200 Merge branch 'ig/nested_h5_group' of https://github.com/ilan-gold/VirtualiZarr into ig/nested_h5_group commit 3036de8 Author: ilan-gold <[email protected]> Date: Sun Sep 7 16:29:44 2025 +0200 fix: remove subgroup check commit 1facb10 Author: Ilan Gold <[email protected]> Date: Sun Sep 7 16:17:43 2025 +0200 fix: wrong place! commit 33e517e Merge: afcaaed c1db925 Author: Ilan Gold <[email protected]> Date: Sun Sep 7 16:17:21 2025 +0200 Merge branch 'main' into ig/nested_h5_group commit afcaaed Author: ilan-gold <[email protected]> Date: Sun Sep 7 16:15:26 2025 +0200 chore: consolidate tests commit 253d184 Author: ilan-gold <[email protected]> Date: Sun Sep 7 15:57:18 2025 +0200 fix: disallow nested xarray handling commit 57551b8 Author: ilan-gold <[email protected]> Date: Fri Aug 29 08:52:28 2025 +0200 chore: relnote commit 6fe1dbd Author: ilan-gold <[email protected]> Date: Fri Aug 29 08:45:57 2025 +0200 fix: typing commit 85f2930 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Aug 28 16:27:24 2025 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit e92ba8c Author: ilan-gold <[email protected]> Date: Thu Aug 28 18:19:46 2025 +0200 fix: simplify node logic commit 323be33 Author: ilan-gold <[email protected]> Date: Thu Aug 28 18:02:04 2025 +0200 feat: nested groups
commit 128138b Author: Max Jones <[email protected]> Date: Thu Nov 13 18:39:24 2025 -0500 Apply suggestion from code review commit 9c0e803 Author: Max Jones <[email protected]> Date: Thu Nov 13 18:25:39 2025 -0500 Apply suggestions from code review Co-authored-by: Chuck Daniels <[email protected]> commit d1595b4 Author: Max Jones <[email protected]> Date: Thu Nov 13 18:25:10 2025 -0500 Update virtualizarr/manifests/store.py Co-authored-by: Chuck Daniels <[email protected]> commit 1573992 Author: Max Jones <[email protected]> Date: Thu Nov 13 18:17:32 2025 -0500 Add test for listing array in subgroup commit dcf80bb Author: Max Jones <[email protected]> Date: Thu Nov 13 15:25:10 2025 -0500 Fix typing commit 2448c5d Author: Max Jones <[email protected]> Date: Thu Nov 13 15:08:33 2025 -0500 Improve ManifestStore.list_dir for arrays and nested groups
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 88.40% 88.45% +0.05%
==========================================
Files 35 35
Lines 2000 2035 +35
==========================================
+ Hits 1768 1800 +32
- Misses 232 235 +3
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
open_virtual_datatreefor virtualizing higher-level hierarchical data structures.Builds on #837
TODO:
Checklist:
docs/releases.rstapi.rst