Skip to content

Commit 348cc7a

Browse files
committed
Add override comments to aioboto3 Session generated methods
1 parent fe7dd9f commit 348cc7a

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

mypy_boto3_builder/parsers/parse_wrapper_package.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,14 @@ def parse_types_aioboto3_package(
100100
ExternalImport(Import.aiobotocore + "session", "ClientCreatorContext"),
101101
[method.return_type],
102102
)
103+
method.type_ignore = "override"
103104
package.session_class.methods.append(method)
104105
for method in parser.get_session_resource_methods():
105106
method.return_type = TypeSubscript(
106107
InternalImport("ResourceCreatorContext"),
107108
[method.return_type],
108109
)
110+
method.type_ignore = "override"
109111
package.session_class.methods.append(method)
110112

111113
for type_annotation in package.session_class.iterate_types():

mypy_boto3_builder/stubs_static/types-aioboto3/session.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class Session(Boto3Session):
2727
profile_name: str | None = ...,
2828
aws_account_id: str | None = ...,
2929
) -> None:
30-
self._session: AioBotocoreSession
30+
self._session: AioBotocoreSession # type: ignore[override]
3131
self.resource_factory: AIOBoto3ResourceFactory # type: ignore[override]
3232
self._loader: Loader
3333

mypy_boto3_builder/templates/types-aioboto3/aioboto3-stubs/session.pyi.jinja2

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,14 @@ from aioboto3.resources.factory import AIOBoto3ResourceFactory
1111
from aiobotocore.config import AioConfig
1212
from aiobotocore.credentials import AioCredentials
1313
from aiobotocore.session import AioSession as AioBotocoreSession
14+
from boto3.session import Session as Boto3Session
1415
from botocore.loaders import Loader
1516

1617
{% for import_record in package.get_session_required_import_records() -%}
1718
{{ import_record -}}{{ "\n" -}}
1819
{% endfor -%}
1920

20-
class Session:
21+
class Session(Boto3Session):
2122
def __init__(
2223
self,
2324
aws_access_key_id: str | None = ...,
@@ -28,10 +29,16 @@ class Session:
2829
profile_name: str | None = ...,
2930
aws_account_id: str | None = ...,
3031
) -> None:
31-
self._session: AioBotocoreSession
32-
self.resource_factory: AIOBoto3ResourceFactory # type: ignore [override]
32+
self._session: AioBotocoreSession # type: ignore[override]
33+
self.resource_factory: AIOBoto3ResourceFactory # type: ignore[override]
3334
self._loader: Loader
3435
def get_credentials(self) -> AioCredentials | None: ...
36+
async def get_available_regions( # type: ignore[override]
37+
self,
38+
service_name: str,
39+
partition_name: str = ...,
40+
allow_non_regional: bool = ...,
41+
) -> list[str]: ...
3542

3643
{% filter indent(4, True) -%}
3744
{% for method in package.session_class.methods -%}

0 commit comments

Comments
 (0)