Widget ignores 'can_add_related'

[andybak]

This should work:

form.field.widget.can_add_related = False

[jpic]

Agreed !

What's your plan ? ;)

[andybak]

We've already got an internal ticket logged for this so you might get your pull request. :)

[jpic]

Brilliant !​

Make sure you take a look at our guidelines (draft):
http://docs.yourlabs.org/

Thanks ;)

[andybak]

OK. Looking over the guidelines - can I check whether this is regarded as a bug fix or new feature? I tend to think the former but there are potential (if unlikely) backwards compatibility issues.

[blueyed]

Yes, I consider it to be a bug fix, too.
As for backwards compatibility, this should be mentioned in the changelog.

[jpic]

If we have a minor backward compatibility break we can increment the middle
version number.​

If it's a short patch feel free to submit the PR directly. If you find it a
bit complicated it's better to talk things out before diving in code.

[jpic]

Hello @andybak

Will you be able to patch this for the next release ? (~2-3 weeks).

Thanks

[jpic]

I think we should somehow wrap our widget in RelatedFieldWidgetWrapper if it's used in the admin.

Not sure how this would be possible ...

[jpic]

Apparently there's no official way to set it: https://code.djangoproject.com/ticket/9071

And it is not supported in inlines: http://stackoverflow.com/questions/26425818/django-1-7-removing-add-button-from-inline-form

How is this supposed to work exactly ?

What code should make what happen and what doesn't ?

Thanks ;)

[andybak]

Sorry for my silence. I just haven't had the time to prioritise this. I'll let you know if that changes.

[jpic]

Don't mention it, but could you at least post a bit more details ? I'll at least have my chance to handle it then ;)

Thanks !

[andybak]

I wasn't aware that can_add_related didn't work with inlines when I created this issue. My use-case is fairly simple - get rid of the damn 'add related' button! (it's results in horrible UX for any inline so I'm baffled that it's hardest to remove in that scenario).

I'm beginning to feel like a hacky solution is probably enough for my case - css, javascript or a template override - at least until the issue is resolved in Django itself.