Psalm type-related issues

[s1lver]

The recent type additions appear somewhat questionable in several places. Many aspects are concerning. For instance, we're running Psalm at error level 1 (with one exception - MixedAssignment) - while 2.0.52 shows no errors, 2.0.53 suddenly reports 197 new errors! Given that Psalm serves as our CI quality gate, these typing changes effectively break backward compatibility.

Yii 2.0.53

 * @psalm-type RegisterJsFileOptions = array{
 *     depends?: class-string[],
 *     position?: int,
 *     appendTimestamp?: boolean
 * }

Code

$this->jsOptions = [
    'type' => 'module',
    'crossorigin' => true,
];

Psalm error level 1:

ERROR: InvalidPropertyAssignmentValue - $this->jsOptions with declared type 'array{appendTimestamp?: bool, depends?: array<array-key, class-string>, position?: int}' cannot be assigned type 'array{crossorigin: true, type: 'module'}' (see https://psalm.dev/145)

We should either be more cautious with such additions or at minimum document them properly in UPGRADE.md

[mspirkov]

Sorry, that was my mistake. I'll fix it now. I'll try to be more attentive in the future.

[mspirkov]

@s1lver Please take a look at this PR

[s1lver]

@s1lver Please take a look at this PR

This is working. But... what about those other 196 bugs?)

I think we should include all typing-related fixes in version 22. What do you think?

[mspirkov]

Could you show me what kind of errors they are?
I would like to keep these annotations for versions >=2.0.53
I'm already using them in several projects. Without them, I'll have to write the same thing in all the inheritors.