Fix #16610: ErrorException trace was cut when using XDebug

Author: Izumi-kun

framework/CHANGELOG.md

@@ -11,6 +11,7 @@ Yii Framework 2 Change Log
 - Enh #16826: `appendTimestamp` support was added to `View` methods `registerCssFile()` and `registerJsFile()` (onmotion)
 - Enh #15526: Show valid aliases and options on invalid input in console application (samdark)
 - Bug #16671: Logging in `Connection::open()` was not respecting `Connection::$enableLogging` (samdark)
+- Bug #16610: ErrorException trace was cut when using XDebug (Izumi-kun)
 
 
 2.0.26 September 03, 2019

framework/base/ErrorException.php

@@ -47,7 +47,7 @@ public function __construct($message = '', $code = 0, $severity = 1, $filename =
         if (function_exists('xdebug_get_function_stack')) {
             // XDebug trace can't be modified and used directly with PHP 7
             // @see https://github.com/yiisoft/yii2/pull/11723
-            $xDebugTrace = array_slice(array_reverse(xdebug_get_function_stack()), 3, -1);
+            $xDebugTrace = array_slice(array_reverse(xdebug_get_function_stack()), 1, -1);
             $trace = [];
             foreach ($xDebugTrace as $frame) {
                 if (!isset($frame['function'])) {

tests/framework/base/ErrorExceptionTest.php

@@ -0,0 +1,29 @@
+<?php
+/**
+ * @link http://www.yiiframework.com/
+ * @copyright Copyright (c) 2008 Yii Software LLC
+ * @license http://www.yiiframework.com/license/
+ */
+
+namespace yiiunit\framework\base;
+
+use yii\base\ErrorException;
+use yiiunit\TestCase;
+
+/**
+ * @group base
+ */
+class ErrorExceptionTest extends TestCase
+{
+    public function testXdebugTrace()
+    {
+        if (!function_exists('xdebug_get_function_stack')) {
+            $this->markTestSkipped('Xdebug are required.');
+        }
+        try {
+            throw new ErrorException();
+        } catch (ErrorException $e){
+            $this->assertEquals(__FUNCTION__, $e->getTrace()[0]['function']);
+        }
+    }
+}