Skip to content

XCOMMONS-3451: Realtime editing doesn't support clustering #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

XCOMMONS-3451: Realtime editing doesn't support clustering #4656

wants to merge 1 commit into from
+1,132 −75

Conversation

@tmortagne
Copy link
Member

@tmortagne tmortagne commented Oct 10, 2025 •
edited
Loading

Depends on xwiki/xwiki-commons#1475.

Jira URL

https://jira.xwiki.org/browse/XCOMMONS-3451

Changes

Description

  • Updates following the xwiki-commons netflux changes
  • Implementation of RemoteUser support
  • Add the cluster member id to local user id in case of an XWiki instance
  • Make modifications go through events (even locally) so that other cluster members know about them

TODO:

  • To limit conflicts, a single node should be the reference (for example the cluster leader) and other nodes receive all updates through it.
  • Add integration tests

Screenshots & Video

Executed Tests

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches: 17.10.x

@tmortagne tmortagne marked this pull request as draft October 10, 2025 14:11
@tmortagne tmortagne force-pushed the feature-realtime-cluster branch 2 times, most recently from d098c66 to 761643f Compare October 13, 2025 15:23
@tmortagne tmortagne changed the title Feature realtime cluster XCOMMONS-3451: Realtime editing doesn't support clustering Oct 13, 2025
@tmortagne tmortagne force-pushed the feature-realtime-cluster branch 2 times, most recently from d49b056 to 78cf964 Compare October 15, 2025 12:41
@tmortagne tmortagne force-pushed the feature-realtime-cluster branch 4 times, most recently from 8fa31ce to 52a6908 Compare October 27, 2025 14:08
@tmortagne tmortagne mentioned this pull request Oct 27, 2025
Open
@tmortagne tmortagne force-pushed the feature-realtime-cluster branch from 52a6908 to f450a1b Compare October 29, 2025 12:19
@tmortagne tmortagne force-pushed the feature-realtime-cluster branch from f450a1b to d73493d Compare November 5, 2025 21:20
@tmortagne tmortagne force-pushed the feature-realtime-cluster branch 3 times, most recently from 81d69b3 to ef92f9d Compare November 21, 2025 16:09
@tmortagne tmortagne force-pushed the feature-realtime-cluster branch 5 times, most recently from d89d2b9 to 8502ccb Compare November 26, 2025 16:41
mflorea
mflorea reviewed Nov 27, 2025
View reviewed changes
Copy link
Member

@mflorea mflorea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tmortagne tmortagne force-pushed the feature-realtime-cluster branch 2 times, most recently from 93b4a6b to 88b6134 Compare December 1, 2025 14:12
@tmortagne tmortagne force-pushed the feature-realtime-cluster branch from 88b6134 to f38987c Compare December 1, 2025 14:51
@tmortagne tmortagne marked this pull request as ready for review December 1, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mflorea mflorea mflorea left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmortagne @mflorea