It broke again

[catfromplan9]

[18:49:25] [Genesis/GameBootstrap/main/INFO] Launching Minecraft 1.8.9 v1_8 (parsed from 1.8.9)
An error occurred while launching Lunar Client.
java.lang.VerifyError: Bad type on operand stack
Exception Details:
  Location:
    com/moonsworth/lunar/genesis/HCOORCHIRRIOHIOCORORRHCOHIORHH.findClass(Ljava/lang/String;)Ljava/lang/Class; @181: invokestatic
  Reason:
    Type 'java/security/ProtectionDomain' (current frame, stack[5]) is not assignable to integer
  Current Frame:
    bci: @181
    flags: { }
    locals: { 'com/moonsworth/lunar/genesis/HCOORCHIRRIOHIOCORORRHCOHIORHH', 'java/lang/String', top, top, 'com/moonsworth/lunar/ichor/util/IOIOHCICRICHRCOICCCHRCHIIORHII', 'java/security/ProtectionDomain' }
    stack: { 'com/moonsworth/lunar/genesis/HCOORCHIRRIOHIOCORORRHCOHIORHH', 'java/lang/String', '[B', integer, integer, 'java/security/ProtectionDomain' }
  Bytecode:
    0000000: 2a2b b600 5a4d 2cc6 0005 2cb0 2b03 b800
    0000010: 4499 000b 2a2b b600 4899 0009 2a2b b800
    0000020: 8eb0 2ab4 0037 2bb9 0094 0200 c000 964e
    0000030: 2dc6 0011 bb00 9859 2b2d b700 9b3a 04a7
    0000040: 002a 2ab4 0039 2b01 2ab6 00a1 3a04 2ab4
    0000050: 00a3 9900 172a b400 3719 04b6 00a6 1904
    0000060: b600 aab9 00ae 0300 572a 1904 b600 a6b6
    0000070: 005a 4d2c c600 052c b0bb 00b0 59bb 00b2
    0000080: 592a 2b12 b412 b6b6 00b9 ba00 bc00 00b6
    0000090: 00c0 01c0 00c2 b700 c501 2a01 b700 c83a
    00000a0: 052a 1904 b600 a619 04b6 00aa 0319 04b6
    00000b0: 00aa be19 05b8 00cc b03a 0519 05b6 00cf
    00000c0: 12d1 b600 d599 00f8 2b3a 062a b400 39b6
    00000d0: 00d9 3a07 1907 b900 df01 0004 6436 0815
    00000e0: 089b 0027 1907 1508 b900 e202 00c0 00e4
    00000f0: 3a09 2ab4 0039 b600 e819 0919 06b6 00ee
    0000100: 3a06 8408 ffa7 ffda b200 f42b ba00 f700
    0000110: 0003 bd00 5cb6 00fd b200 f419 05b6 00cf
    0000120: ba01 0000 0003 bd00 5cb6 00fd b200 f419
    0000130: 04b6 00aa b801 06b8 010a ba01 0d00 0003
    0000140: bd00 5cb6 00fd b200 f42b 1904 b600 a6ba
    0000150: 0112 0000 03bd 005c b600 fd04 3608 1907
    0000160: b901 1601 003a 0919 09b9 011c 0100 9900
    0000170: 4f19 09b9 0120 0100 c000 e43a 0a2a b400
    0000180: 39b6 00e8 190a 1906 b601 223a 0b19 0b19
    0000190: 06b6 0052 9a00 22b2 00f4 1508 190a b901
    00001a0: 2501 0019 0619 0bba 012a 0000 03bd 005c
    00001b0: b600 fd84 0801 190b 3a06 a7ff ad19 05bf
    00001c0:                                        
  Exception Handler Table:
    bci [121, 184] => handler: 185
  Stackmap Table:
    same_frame(@12)
    same_frame(@28)
    same_frame(@34)
    same_frame(@66)
    append_frame(@105,Top,Top,Object[#152])
    same_frame(@121)
    same_locals_1_stack_item_frame(@185,Object[#137])
    full_frame(@223,{Object[#2],Object[#78],Top,Top,Object[#152],Object[#137],Object[#78],Object[#219],Integer},{})
    chop_frame(@264,1)
    full_frame(@359,{Object[#2],Top,Top,Top,Top,Object[#137],Object[#78],Top,Integer,Object[#280]},{})
    full_frame(@438,{Object[#2],Top,Top,Top,Top,Object[#137],Top,Top,Integer,Object[#280],Top,Object[#78]},{})
    full_frame(@445,{Top,Top,Top,Top,Top,Object[#137]},{})

	at com.moonsworth.lunar.genesis.ClientGameBootstrap.apply(Unknown Source)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at com.moonsworth.lunar.genesis.CHCRHIOIRHHIRHIRCOCOOOIICICRRI.CHCRHIOIRHHIRHIRCOCOOOIICICRRI(Unknown Source)
	at com.moonsworth.lunar.genesis.Genesis.run(Unknown Source)
	at com.moonsworth.lunar.genesis.Genesis.main(Unknown Source)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at wtf.zani.llw.core.launch.LaunchKt.launch(Launch.kt:148)
	at wtf.zani.llw.cli.MainKt.main(Main.kt:114)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:105)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Sending Sentry with this report...
Sending event to Sentry: 8df1d958797b47d99b9218882452717e (java.lang.VerifyError: Bad type on operand stack
Exception Details:
  Location:
    com/moonsworth/lunar/genesis/HCOORCHIRRIOHIOCORORRHCOHIORHH.findClass(Ljava/lang/String;)Ljava/lang/Class; @181: invokestatic
  Reason:
    Type 'java/security/ProtectionDomain' (current frame, stack[5]) is not assignable to integer
  Current Frame:
    bci: @181
    flags: { }
    locals: { 'com/moonsworth/lunar/genesis/HCOORCHIRRIOHIOCORORRHCOHIORHH', 'java/lang/String', top, top, 'com/moonsworth/lunar/ichor/util/IOIOHCICRICHRCOICCCHRCHIIORHII', 'java/security/ProtectionDomain' }
    stack: { 'com/moonsworth/lunar/genesis/HCOORCHIRRIOHIOCORORRHCOHIORHH', 'java/lang/String', '[B', integer, integer, 'java/security/ProtectionDomain' }
  Bytecode:
    0000000: 2a2b b600 5a4d 2cc6 0005 2cb0 2b03 b800
    0000010: 4499 000b 2a2b b600 4899 0009 2a2b b800
    0000020: 8eb0 2ab4 0037 2bb9 0094 0200 c000 964e
    0000030: 2dc6 0011 bb00 9859 2b2d b700 9b3a 04a7
    0000040: 002a 2ab4 0039 2b01 2ab6 00a1 3a04 2ab4
    0000050: 00a3 9900 172a b400 3719 04b6 00a6 1904
    0000060: b600 aab9 00ae 0300 572a 1904 b600 a6b6
    0000070: 005a 4d2c c600 052c b0bb 00b0 59bb 00b2
    0000080: 592a 2b12 b412 b6b6 00b9 ba00 bc00 00b6
    0000090: 00c0 01c0 00c2 b700 c501 2a01 b700 c83a
    00000a0: 052a 1904 b600 a619 04b6 00aa 0319 04b6
    00000b0: 00aa be19 05b8 00cc b03a 0519 05b6 00cf
    00000c0: 12d1 b600 d599 00f8 2b3a 062a b400 39b6
    00000d0: 00d9 3a07 1907 b900 df01 0004 6436 0815
    00000e0: 089b 0027 1907 1508 b900 e202 00c0 00e4
    00000f0: 3a09 2ab4 0039 b600 e819 0919 06b6 00ee
    0000100: 3a06 8408 ffa7 ffda b200 f42b ba00 f700
    0000110: 0003 bd00 5cb6 00fd b200 f419 05b6 00cf
    0000120: ba01 0000 0003 bd00 5cb6 00fd b200 f419
    0000130: 04b6 00aa b801 06b8 010a ba01 0d00 0003
    0000140: bd00 5cb6 00fd b200 f42b 1904 b600 a6ba
    0000150: 0112 0000 03bd 005c b600 fd04 3608 1907
    0000160: b901 1601 003a 0919 09b9 011c 0100 9900
    0000170: 4f19 09b9 0120 0100 c000 e43a 0a2a b400
    0000180: 39b6 00e8 190a 1906 b601 223a 0b19 0b19
    0000190: 06b6 0052 9a00 22b2 00f4 1508 190a b901
    00001a0: 2501 0019 0619 0bba 012a 0000 03bd 005c
    00001b0: b600 fd84 0801 190b 3a06 a7ff ad19 05bf
    00001c0:                                        
  Exception Handler Table:
    bci [121, 184] => handler: 185
  Stackmap Table:
    same_frame(@12)
    same_frame(@28)
    same_frame(@34)
    same_frame(@66)
    append_frame(@105,Top,Top,Object[#152])
    same_frame(@121)
    same_locals_1_stack_item_frame(@185,Object[#137])
    full_frame(@223,{Object[#2],Object[#78],Top,Top,Object[#152],Object[#137],Object[#78],Object[#219],Integer},{})
    chop_frame(@264,1)
    full_frame(@359,{Object[#2],Top,Top,Top,Top,Object[#137],Object[#78],Top,Integer,Object[#280]},{})
    full_frame(@438,{Object[#2],Top,Top,Top,Top,Object[#137],Top,Top,Integer,Object[#280],Top,Object[#78]},{})
    full_frame(@445,{Top,Top,Top,Top,Top,Object[#137]},{})
)
Process exited with code 1.

[xoogal]

Is this latest commit to the v2 branch? If I can reproduce this I'll have it fixed ASAP.

[catfromplan9]

Is this latest commit to the v2 branch? If I can reproduce this I'll have it fixed ASAP.

Yes

[catfromplan9]

Also how do I block auto updates and is there a way to download old LC

[xoogal]

I haven't managed to reproduce this in a dev environment yet, launching seems to work correctly on my end. It could be that an update rolled out earlier to you than it did to me. I'll keep an eye on it over the next few days.

Also how do I block auto updates and is there a way to download old LC

I might run a service to cache LC updates at some point, until then old versions won't be supported. To prevent updating you should be able to tack --skip-download on to the end of your CLI arguments (represented by minecraftArguments in most launchers). No guarantee skipping the download won't cause unforeseen issues (the latest manifest is fetched regardless of whether or not you're actually downloading LC), but it should mostly work.

If you want to take a shot at expanding CLI functionality I am open to PRs.

[catfromplan9]

CLI arguments (represented by minecraftArguments in most launchers)

No idea what these are, can you just make it a JVM arg? E.g. -Dllw.skip_download=true? You can use Boolean.getBoolean("llw.skip_download") for that