From 11c95b9fcda75e09cc3d3fee76fe6b3a117d0caa Mon Sep 17 00:00:00 2001
From: Ruben van Leeuwen <ruben.vanleeuwen@surf.nl>
Date: Tue, 14 May 2024 11:47:10 +0200
Subject: [PATCH 1/2] Fix some console warnings about aria-labels

---
 .../src/components/WfoDiff/WfoDiff.tsx                   | 9 ++++++++-
 .../WfoTable/WfoTableWithFilter/WfoTableWithFilter.tsx   | 1 +
 .../orchestrator-ui-components/src/messages/en-GB.json   | 6 +++++-
 .../orchestrator-ui-components/src/messages/nl-NL.json   | 6 +++++-
 .../pages/processes/WfoProductInformationWithLink.tsx    | 6 +++++-
 5 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/packages/orchestrator-ui-components/src/components/WfoDiff/WfoDiff.tsx b/packages/orchestrator-ui-components/src/components/WfoDiff/WfoDiff.tsx
index 8ee57c233..3278c5f4b 100644
--- a/packages/orchestrator-ui-components/src/components/WfoDiff/WfoDiff.tsx
+++ b/packages/orchestrator-ui-components/src/components/WfoDiff/WfoDiff.tsx
@@ -95,6 +95,11 @@ const WfoDiff: FC<WfoDiffProps> = ({ oldText, newText, syntax }) => {
                                 : 'continuityWithin'
                         }
                         onClick={() => setShowSplit(!showSplit)}
+                        aria-label={t(
+                            showSplit
+                                ? 'continuityAboveBelow'
+                                : 'continuityWithin',
+                        )}
                     />
                 </EuiFlexItem>
                 <EuiFlexItem grow={false}>
@@ -102,10 +107,12 @@ const WfoDiff: FC<WfoDiffProps> = ({ oldText, newText, syntax }) => {
                         size={'s'}
                         iconType={showFull ? 'fullScreenExit' : 'fullScreen'}
                         onClick={() => setShowFull(!showFull)}
+                        aria-label={t(
+                            showFull ? 'fullScreenExit' : 'fullScreen',
+                        )}
                     />
                 </EuiFlexItem>
             </EuiFlexGroup>
-
             <EuiSpacer />
             <Diff
                 css={diffStyle}
diff --git a/packages/orchestrator-ui-components/src/components/WfoTable/WfoTableWithFilter/WfoTableWithFilter.tsx b/packages/orchestrator-ui-components/src/components/WfoTable/WfoTableWithFilter/WfoTableWithFilter.tsx
index cea01f2d2..4eaa01e45 100644
--- a/packages/orchestrator-ui-components/src/components/WfoTable/WfoTableWithFilter/WfoTableWithFilter.tsx
+++ b/packages/orchestrator-ui-components/src/components/WfoTable/WfoTableWithFilter/WfoTableWithFilter.tsx
@@ -226,6 +226,7 @@ export const WfoTableWithFilter = <T extends object>({
                         onClick={() => setShowSearchModal(true)}
                         iconSize={'xl'}
                         iconType={'iInCircle'}
+                        aria-label={t('searchModalTitle')}
                     />
                 </EuiFlexItem>
                 <EuiButton onClick={() => setShowSettingsModal(true)}>
diff --git a/packages/orchestrator-ui-components/src/messages/en-GB.json b/packages/orchestrator-ui-components/src/messages/en-GB.json
index 432addf60..c91dd3d1b 100644
--- a/packages/orchestrator-ui-components/src/messages/en-GB.json
+++ b/packages/orchestrator-ui-components/src/messages/en-GB.json
@@ -230,7 +230,11 @@
             "traceback": "Traceback"
         },
         "delta": {
-            "title": "Subscription delta"
+            "title": "Subscription delta",
+            "fullScreenExit": "Exit full-screen mode",
+            "fullScreen": "Full-screen mode",
+            "continuityAboveBelow": "Continuity above below",
+            "continuityWithin": "Continuity within"
         }
     },
     "workflows": {
diff --git a/packages/orchestrator-ui-components/src/messages/nl-NL.json b/packages/orchestrator-ui-components/src/messages/nl-NL.json
index 5c0fc0e15..ceae138b2 100644
--- a/packages/orchestrator-ui-components/src/messages/nl-NL.json
+++ b/packages/orchestrator-ui-components/src/messages/nl-NL.json
@@ -230,7 +230,11 @@
             "traceback": "Traceback"
         },
         "delta": {
-            "title": "Subscription delta"
+            "title": "Subscription delta",
+            "fullScreenExit": "Exit full-screen mode",
+            "fullScreen": "Full-screen mode",
+            "continuityAboveBelow": "Continuity above below",
+            "continuityWithin": "Continuity within"
         }
     },
     "workflows": {
diff --git a/packages/orchestrator-ui-components/src/pages/processes/WfoProductInformationWithLink.tsx b/packages/orchestrator-ui-components/src/pages/processes/WfoProductInformationWithLink.tsx
index 3ead7bb22..300104cd4 100644
--- a/packages/orchestrator-ui-components/src/pages/processes/WfoProductInformationWithLink.tsx
+++ b/packages/orchestrator-ui-components/src/pages/processes/WfoProductInformationWithLink.tsx
@@ -24,7 +24,11 @@ export const WfoProductInformationWithLink = ({
             {showWorkflowInformationLink && (
                 <EuiToolTip content={t('openWorkflowTaskInfo')}>
                     <a href={docsUrl} target="_blank">
-                        <EuiButtonIcon iconSize={'l'} iconType={'iInCircle'} />
+                        <EuiButtonIcon
+                            iconSize={'l'}
+                            iconType={'iInCircle'}
+                            aria-label={t('openWorkflowTaskInfo')}
+                        />
                     </a>
                 </EuiToolTip>
             )}

From 862283647282a056e1f15f15abb6e02ca00254c4 Mon Sep 17 00:00:00 2001
From: Ruben van Leeuwen <ruben.vanleeuwen@surf.nl>
Date: Tue, 14 May 2024 15:56:34 +0200
Subject: [PATCH 2/2] Add changeset

---
 .changeset/rich-doors-lay.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/rich-doors-lay.md

diff --git a/.changeset/rich-doors-lay.md b/.changeset/rich-doors-lay.md
new file mode 100644
index 000000000..511b1d1e1
--- /dev/null
+++ b/.changeset/rich-doors-lay.md
@@ -0,0 +1,5 @@
+---
+"@orchestrator-ui/orchestrator-ui-components": patch
+---
+
+Fixes missing aria-labels on icons