Removing all deprecated endpoints and functions (#599)

* Remove Fixed Input endpoint as it is unused

* Deprecated unsed API endpoints. Removed some custom validators and migrated to SURF specific.

* Removed all deprecated endpoints, schemas and functions.

* Added Unit test for base serializer

* Black

* Rc1

Author: pboers1988

.bumpversion.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 2.2.2
+current_version = 2.3.0rc1
 commit = False
 tag = False
 parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(rc(?P<build>\d+))?

orchestrator/__init__.py

@@ -13,7 +13,7 @@
 
 """This is the orchestrator workflow engine."""
 
-__version__ = "2.2.2"
+__version__ = "2.3.0rc1"
 
 from orchestrator.app import OrchestratorCore
 from orchestrator.settings import app_settings, oauth2_settings

orchestrator/api/api_v1/api.py

@@ -17,50 +17,27 @@
 from fastapi.routing import APIRouter
 
 from orchestrator.api.api_v1.endpoints import (
-    fixed_input,
     health,
     processes,
-    product_blocks,
     products,
-    resource_types,
     settings,
     subscription_customer_descriptions,
     subscriptions,
     translations,
     user,
-    workflows,
     ws,
 )
 from orchestrator.security import opa_security_default
 
 api_router = APIRouter()
-api_router.include_router(
-    fixed_input.router,
-    prefix="/fixed_inputs",
-    tags=["Core", "Fixed Inputs"],
-    dependencies=[Depends(opa_security_default)],
-)
 
 api_router.include_router(
     processes.router, prefix="/processes", tags=["Core", "Processes"], dependencies=[Depends(opa_security_default)]
 )
 api_router.include_router(processes.ws_router, prefix="/processes", tags=["Core", "Processes"])
-
-api_router.include_router(
-    product_blocks.router,
-    prefix="/product_blocks",
-    tags=["Core", "Product Blocks"],
-    dependencies=[Depends(opa_security_default)],
-)
 api_router.include_router(
     products.router, prefix="/products", tags=["Core", "Product"], dependencies=[Depends(opa_security_default)]
 )
-api_router.include_router(
-    resource_types.router,
-    prefix="/resource_types",
-    tags=["Core", "Resource Types"],
-    dependencies=[Depends(opa_security_default)],
-)
 api_router.include_router(
     subscriptions.router,
     prefix="/subscriptions",
@@ -76,9 +53,6 @@
 api_router.include_router(
     user.router, prefix="/user", tags=["Core", "User"], dependencies=[Depends(opa_security_default)]
 )
-api_router.include_router(
-    workflows.router, prefix="/workflows", tags=["Core", "Workflows"], dependencies=[Depends(opa_security_default)]
-)
 api_router.include_router(
     settings.router, prefix="/settings", tags=["Core", "Settings"], dependencies=[Depends(opa_security_default)]
 )

orchestrator/api/api_v1/endpoints/fixed_input.py

@@ -28,14 +28,13 @@
 from more_itertools import chunked
 from sentry_sdk.tracing import trace
 from sqlalchemy import CompoundSelect, Select, select
-from sqlalchemy.orm import contains_eager, defer, joinedload
+from sqlalchemy.orm import defer, joinedload
 from sqlalchemy.sql.functions import count
 from starlette.responses import Response
 
 from oauth2_lib.fastapi import OIDCUserModel
 from orchestrator.api.error_handling import raise_status
 from orchestrator.api.helpers import add_response_range
-from orchestrator.config.assignee import Assignee
 from orchestrator.db import ProcessSubscriptionTable, ProcessTable, SubscriptionTable, db
 from orchestrator.db.filters import Filter
 from orchestrator.db.filters.process import filter_processes
@@ -46,8 +45,6 @@
     ProcessResumeAllSchema,
     ProcessSchema,
     ProcessStatusCounts,
-    ProcessSubscriptionBaseSchema,
-    ProcessSubscriptionSchema,
     Reporter,
 )
 from orchestrator.security import oidc_user
@@ -65,7 +62,6 @@
 from orchestrator.services.settings import get_engine_settings
 from orchestrator.settings import app_settings
 from orchestrator.types import JSON, State
-from orchestrator.utils.deprecation_logger import deprecated_endpoint
 from orchestrator.utils.enrich_process import enrich_process
 from orchestrator.websocket import WS_CHANNELS, send_process_data_to_websocket, websocket_manager
 from orchestrator.workflow import ProcessStatus
@@ -230,46 +226,6 @@ def abort_process_endpoint(process_id: UUID, request: Request, user: str = Depen
         raise_status(HTTPStatus.INTERNAL_SERVER_ERROR, str(e))
 
 
-@router.get(
-    "/process-subscriptions-by-subscription-id/{subscription_id}",
-    response_model=list[ProcessSubscriptionSchema],
-    deprecated=True,
-    description="This endpoint is deprecated and will be removed in a future release. Please use the GraphQL query",
-    dependencies=[Depends(deprecated_endpoint)],
-)
-def process_subscriptions_by_subscription_id(subscription_id: UUID) -> list[ProcessSubscriptionSchema]:
-    stmt = (
-        select(ProcessSubscriptionTable)
-        .options(contains_eager(ProcessSubscriptionTable.process))
-        .join(ProcessTable)
-        .filter(ProcessSubscriptionTable.subscription_id == subscription_id)
-        .order_by(ProcessTable.started_at.asc())
-    )
-    return list(db.session.scalars(stmt))
-
-
-@router.get(
-    "/process-subscriptions-by-process_id/{process_id}",
-    response_model=list[ProcessSubscriptionBaseSchema],
-    deprecated=True,
-    description="This endpoint is deprecated and will be removed in a future release. Please use the GraphQL query",
-    dependencies=[Depends(deprecated_endpoint)],
-)
-def process_subscriptions_by_process_process_id(process_id: UUID) -> list[ProcessSubscriptionTable]:
-    return list(db.session.scalars(select(ProcessSubscriptionTable).filter_by(process_id=process_id)))
-
-
-@router.get(
-    "/statuses",
-    response_model=list[ProcessStatus],
-    deprecated=True,
-    description="This endpoint is deprecated and will be removed in a future release. Please use the GraphQL query",
-    dependencies=[Depends(deprecated_endpoint)],
-)
-def statuses() -> list[str]:
-    return [status.value for status in ProcessStatus]
-
-
 @router.get("/status-counts", response_model=ProcessStatusCounts)
 def status_counts() -> ProcessStatusCounts:
     """Retrieve status counts for processes and tasks."""
@@ -286,17 +242,6 @@ def status_counts() -> ProcessStatusCounts:
     )
 
 
-@router.get(
-    "/assignees",
-    response_model=list[Assignee],
-    deprecated=True,
-    description="This endpoint is deprecated and will be removed in a future release. Please use the GraphQL query",
-    dependencies=[Depends(deprecated_endpoint)],
-)
-def assignees() -> list[str]:
-    return [assignee.value for assignee in Assignee]
-
-
 @router.get("/{process_id}", response_model=ProcessSchema)
 def show(process_id: UUID) -> dict[str, Any]:
     process = _get_process(process_id)