feat(tg_bot): /watch resolves and stores stock name from backend

Fixes review issue OpenByteInc#10 — /list previously showed `—` for every code
because cmd_watch always passed name=None and watchlist_add was
INSERT OR IGNORE.

Three coordinated changes:

1. QuantDingerClient.get_symbol_name() hits the public
   GET /api/market/symbols/search endpoint (unauthed; seed DB lookup),
   returns the first result's name or None on any error / no match /
   symbol-echo. Best-effort, never raises.

2. Storage.watchlist_add now uses UPSERT with COALESCE(old, new) so:
   - existing name is never overwritten (preserves prior intent)
   - existing NULL name CAN be backfilled by a later add with a real
     name (matches the lazy-fill use case)
   added_by / added_at stay from the original insert.

3. cmd_watch awaits get_symbol_name before storing; passes the result
   through. Reply now echoes the name when available
   (e.g. "✅ 已加入 watchlist: 600519  貴州茅台").

Pre-existing watchlist rows with NULL name will stay NULL until
re-watched; users wanting to backfill can /unwatch + /watch the code.

Tests: +5 (1 storage backfill, 4 get_symbol_name covering happy /
no-match / symbol-echo / HTTP 500). Full suite 61/61.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: admin

tg_bot/handlers/watchlist.py

@@ -28,14 +28,18 @@ async def _err(msg: Message, text: str):
 
 
 @router.message(Command("watch"))
-async def cmd_watch(msg: Message, storage: Storage):
+async def cmd_watch(msg: Message, storage: Storage, quantdinger):
     try:
         code = parse_code(msg.text or "")
     except ValueError as e:
         await _err(msg, str(e))
         return
-    storage.watchlist_add(code, name=None, added_by=msg.from_user.id)
-    await msg.answer(f"✅ 已加入 watchlist：<code>{code}</code>", parse_mode="HTML")
+    # Best-effort name lookup; on any failure the row still gets added with
+    # name=None (later /ai or /scan can backfill it via run_analysis).
+    name = await quantdinger.get_symbol_name(market="CNStock", symbol=code)
+    storage.watchlist_add(code, name=name, added_by=msg.from_user.id)
+    label = f"<code>{code}</code>" + (f"  {name}" if name else "")
+    await msg.answer(f"✅ 已加入 watchlist：{label}", parse_mode="HTML")
 
 
 @router.message(Command("unwatch"))

tg_bot/services/quantdinger.py

@@ -87,6 +87,39 @@ async def analyze(self, *, market: str, symbol: str, language: str = "zh-TW",
             )
         raise BackendError(msg, code=resp.status_code, data=data)
 
+    async def get_symbol_name(self, *, market: str, symbol: str) -> str | None:
+        """Look up a human-readable name for a symbol.
+
+        Hits the public-ish endpoint `GET /api/market/symbols/search` which
+        queries the seeded symbol DB. Returns None on any error (404, timeout,
+        no match, network) — caller is expected to degrade gracefully.
+
+        This endpoint does not require auth, so we don't bother attaching a
+        Bearer token; staying unauthed avoids cascading 401 retries when the
+        bot is in a partial-startup state.
+        """
+        try:
+            resp = await self._client.get(
+                f"{self.base}/api/market/symbols/search",
+                params={"market": market, "keyword": symbol, "limit": 1},
+                timeout=8.0,
+            )
+            if resp.status_code != 200:
+                return None
+            payload = resp.json() or {}
+        except Exception:
+            return None
+        items = payload.get("data") or []
+        if not items or not isinstance(items, list):
+            return None
+        first = items[0] or {}
+        name = (first.get("name") or "").strip()
+        # Backend sometimes echoes the symbol as name when no real name found;
+        # treat that as "no name" so we don't pollute the watchlist.
+        if not name or name.upper() == str(symbol).upper():
+            return None
+        return name
+
     async def _post_authed(self, path: str, *, json: dict) -> httpx.Response:
         """POST that auto re-logins once on 401."""
         token = await self._ensure_token()

tg_bot/services/storage.py

@@ -74,9 +74,12 @@ def close(self) -> None:
 
     # ---- watchlist ----
     def watchlist_add(self, code: str, name: str | None, added_by: int) -> None:
+        # COALESCE keeps the old name if already set; new non-null name backfills NULL.
+        # added_by / added_at stay from the original insert.
         with self._conn:
             self._conn.execute(
-                "INSERT OR IGNORE INTO watchlist(code, name, added_by, added_at) VALUES (?,?,?,?)",
+                "INSERT INTO watchlist(code, name, added_by, added_at) VALUES (?,?,?,?) "
+                "ON CONFLICT(code) DO UPDATE SET name = COALESCE(watchlist.name, excluded.name)",
                 (code, name, added_by, _now_iso()),
             )
 

tg_bot/tests/test_quantdinger.py

@@ -93,3 +93,40 @@ async def test_analyze_insufficient_credits(client):
                              language="zh-TW", timeframe="1D")
     assert "credits" in str(exc.value).lower()
     await client.aclose()
+
+
+@respx.mock
+async def test_get_symbol_name_returns_name(client):
+    respx.get(f"{BASE}/api/market/symbols/search").mock(return_value=httpx.Response(
+        200, json={"code": 1, "msg": "success",
+                   "data": [{"market": "CNStock", "symbol": "600519", "name": "貴州茅台"}]}))
+    name = await client.get_symbol_name(market="CNStock", symbol="600519")
+    assert name == "貴州茅台"
+    await client.aclose()
+
+
+@respx.mock
+async def test_get_symbol_name_no_match_returns_none(client):
+    respx.get(f"{BASE}/api/market/symbols/search").mock(return_value=httpx.Response(
+        200, json={"code": 1, "data": []}))
+    name = await client.get_symbol_name(market="CNStock", symbol="999999")
+    assert name is None
+    await client.aclose()
+
+
+@respx.mock
+async def test_get_symbol_name_echo_symbol_treated_as_none(client):
+    """When backend echoes the symbol as name (no real match), treat as None."""
+    respx.get(f"{BASE}/api/market/symbols/search").mock(return_value=httpx.Response(
+        200, json={"code": 1, "data": [{"symbol": "600519", "name": "600519"}]}))
+    name = await client.get_symbol_name(market="CNStock", symbol="600519")
+    assert name is None
+    await client.aclose()
+
+
+@respx.mock
+async def test_get_symbol_name_http_error_returns_none(client):
+    respx.get(f"{BASE}/api/market/symbols/search").mock(return_value=httpx.Response(500))
+    name = await client.get_symbol_name(market="CNStock", symbol="600519")
+    assert name is None
+    await client.aclose()

tg_bot/tests/test_storage.py

@@ -29,6 +29,19 @@ def test_watchlist_add_dup_is_noop(storage):
     assert rows[0]["name"] == "貴州茅台"
 
 
+def test_watchlist_add_backfills_null_name(storage):
+    """If a row was inserted with name=None, a later add with a real name fills it in."""
+    storage.watchlist_add("600519", None, added_by=111)
+    rows = storage.watchlist_list()
+    assert rows[0]["name"] is None
+    storage.watchlist_add("600519", "貴州茅台", added_by=222)
+    rows = storage.watchlist_list()
+    assert len(rows) == 1
+    assert rows[0]["name"] == "貴州茅台"
+    # added_by stays from the original insert (we don't overwrite it)
+    assert rows[0]["added_by"] == 111
+
+
 def test_watchlist_remove(storage):
     storage.watchlist_add("600519", "貴州茅台", added_by=111)
     removed = storage.watchlist_remove("600519")