fix: fetch MLS public keys the same way as feature config [WPB-17161] #3991

saleniuk · 2025-04-15T14:17:09Z

WPB-17161 [Android] Excessive frequency of fetching MLS public keys

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Fetching MLS public keys should be treated the same way as feature-configs.
https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/160858877/Feature+flags+and+feature+configuration#Periodic-fetch-of-configuration

Solutions

Add fetching MLS public keys to the AppSyncViewModel. Update kalium version to the one with MLS public keys changes to be able to use MLSPublicKeysSyncWorker (it executes fetch every 24h as well).

Update: use ForegroundActionsUseCase instead - solution implemented in this PR: wireapp/kalium#3527

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…droid [WPB-11304] (#3935) Co-authored-by: yamilmedina <[email protected]>

Co-authored-by: Mohamad Jaara <[email protected]>

This reverts commit 5c4e3d8.

… [WPB-17078] (#3977)

(cherry picked from commit 542f53c)

github-actions · 2025-06-17T12:20:44Z

Built wire-android-staging-compat-pr-3991.apk is available for download

github-actions · 2025-06-17T12:21:00Z

Built wire-android-dev-debug-pr-3991.apk is available for download

…ic-keys-on-foreground # Conflicts: # kalium

github-actions · 2025-07-15T11:33:51Z

Built wire-android-staging-compat-pr-3991.apk is available for download

github-actions · 2025-07-15T11:34:14Z

Built wire-android-dev-debug-pr-3991.apk is available for download

app/src/main/kotlin/com/wire/android/ui/home/AppSyncViewModel.kt

…ic-keys-on-foreground # Conflicts: # kalium

github-actions · 2025-07-17T13:00:32Z

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
bbf3c87c6319309441466844df96f2463310c5db	f2e3db432ccda367dde9e817cb74fbaec4ce3c9a

Is this intentional?

github-actions · 2025-07-17T13:09:19Z

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
bbf3c87c6319309441466844df96f2463310c5db	41a98896313c998d6638a1d4c9654a71ac6fbb7d

Is this intentional?

github-actions · 2025-07-17T13:54:34Z

Built wire-android-staging-compat-pr-3991.apk is available for download

github-actions · 2025-07-17T13:54:49Z

Built wire-android-dev-debug-pr-3991.apk is available for download

…ic-keys-on-foreground # Conflicts: # kalium

sonarqubecloud · 2025-07-17T16:16:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-07-17T17:15:45Z

Built wire-android-staging-compat-pr-3991.apk is available for download

github-actions · 2025-07-17T17:16:08Z

Built wire-android-dev-debug-pr-3991.apk is available for download

MohamadJaara and others added 30 commits March 13, 2025 15:44

chore: disable picture in picture

0a20227

fix: broken test for AnonymousAnalyticsManagerTest

478667b

fix: broken class ExternalLoggerManager for flavor

5f4ebf7

fix: broken tests for flavored runs

af6cb19

fix: disable in-call reactions while connecting [WPB-16372] (#3916)

ca62a1a

fix: crashes on audio message playback [WPB-16195] (#3917)

63637e3

chore: run connected tests on dev flavour [WPB-16596] (#3925)

a6254ef

fix: persist self email to register device with 2fa [WPB-16573] (#3929)

a57eadc

chore: update kalium

2166088

fix: app crashing when sharing location form a modified version of an…

63a7f60

…droid [WPB-11304] (#3935) Co-authored-by: yamilmedina <[email protected]>

fix: analytics should be disabled for c-builds (WPB-16675) (#3940)

0fe8ab1

Co-authored-by: Mohamad Jaara <[email protected]>

fix: handle 2fa on RegisterDeviceScreen [WPB-16573] (#3934)

b843e93

chore: update kalium

e0fce29

chore: release notes for 4.11.0

e6bc0f6

fix: compare versions in the build script

4cf7ca3

chore: bump version to 4.11.1

5c4e3d8

chore: update kalium

42e658b

fix: prod builder script not running

073894e

fix: prod builder script not running

d8912c3

fix: prod builder script not running

360acc6

feat: database optimizer [WPB-16842] (#3950)

add996f

Co-authored-by: Mohamad Jaara <[email protected]>

fix: audio recording and playing crashes [WPB-16687] [WPB-16835] (#3955)

58ae553

Revert "chore: bump version to 4.11.1"

64909ed

This reverts commit 5c4e3d8.

chore: bump upload artifact action

5d77493

chore: bump version to 4.11.1

5e618ca

fix: make sure coroutine is init before using it on analytics manager…

00c3613

… [WPB-17078] (#3977)

test: speed up tests [WPB-8645] (#3964)

075cb91

(cherry picked from commit 542f53c)

chore: update kalium

3a369c8

chore: bump core crypto to 3.1.1

7601617

fix: fetch MLS public keys the same way as feature config [WPB-17161]

e763dff

MohamadJaara removed the DO NOT MERGE label Jul 15, 2025

MohamadJaara approved these changes Jul 15, 2025

View reviewed changes

Merge remote-tracking branch 'origin/develop' into fix/fetch-mls-publ…

9afe3ae

…ic-keys-on-foreground # Conflicts: # kalium

vitorhugods reviewed Jul 15, 2025

View reviewed changes

app/src/main/kotlin/com/wire/android/ui/home/AppSyncViewModel.kt Outdated Show resolved Hide resolved

saleniuk requested a review from vitorhugods July 15, 2025 12:47

saleniuk added 4 commits July 16, 2025 20:49

Merge remote-tracking branch 'origin/develop' into fix/fetch-mls-publ…

08f8b8a

…ic-keys-on-foreground # Conflicts: # kalium

use new ForegroundActionsUseCase

06891fb

Merge remote-tracking branch 'origin/develop' into fix/fetch-mls-publ…

c9b576b

…ic-keys-on-foreground # Conflicts: # kalium

use new kalium version

1c6fdcb

pull-request-size bot added size/S and removed size/XS labels Jul 17, 2025

update kalium ref

a98a9e7

Garzas approved these changes Jul 17, 2025

View reviewed changes

saleniuk added 2 commits July 17, 2025 18:13

Merge remote-tracking branch 'origin/develop' into fix/fetch-mls-publ…

d78d61b

…ic-keys-on-foreground # Conflicts: # kalium

update kalium ref

4b39fce

saleniuk added this pull request to the merge queue Jul 17, 2025

Merged via the queue into develop with commit d9a4950 Jul 17, 2025
17 of 19 checks passed

saleniuk deleted the fix/fetch-mls-public-keys-on-foreground branch July 17, 2025 18:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: fetch MLS public keys the same way as feature config [WPB-17161] #3991

fix: fetch MLS public keys the same way as feature config [WPB-17161] #3991

Uh oh!

saleniuk commented Apr 15, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

sonarqubecloud bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

fix: fetch MLS public keys the same way as feature config [WPB-17161] #3991

fix: fetch MLS public keys the same way as feature config [WPB-17161] #3991

Uh oh!

Conversation

saleniuk commented Apr 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solutions

Dependencies (Optional)

Testing

Test Coverage (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

sonarqubecloud bot commented Jul 17, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

saleniuk commented Apr 15, 2025 •

edited by github-actions bot

Loading