GameNetworkManager Patching

[D1GQ]

Hey @winstxnhdw Is there be any reason why I can't patch something private in GameNetworkManager?

[winstxnhdw]

What do you mean? There should be nothing stopping you.

[D1GQ]

Ah

[winstxnhdw]

You can't check for the second option and this is not exactly solid evidence to show that it is handled by the client. It is likely all connection approvals are done by the host and there's nothing you can do about it as a client.

The best you can do is check what other mods are looking for in the request and then try and modify that.

[winstxnhdw]

Looking into their AdvancedCompany's source code, it checks for this.

        [HarmonyPatch(typeof(global::Unity.Netcode.ConnectionRequestMessage), "Deserialize")]
        [HarmonyPostfix]
        static void ReadConnectData(global::Unity.Netcode.ConnectionRequestMessage __instance, ref bool __result, FastBufferReader reader, NetworkContext context, int receivedMessageVersion)
        {
            NetworkManager networkManager = (NetworkManager)context.SystemOwner;
            var handshake = new Lib.Sync();
            handshake.ClientId = context.SenderId;
            handshake.ConfigHash = __instance.ConfigHash;
            ConnectingClients.Add(context.SenderId, handshake);

            try
            {
                if (__result)
                {
                    if (reader.Length > reader.Position)
                    {
                        if ((Network.Manager.Lobby.IsJoinable || ServerConfiguration.Instance.Lobby.KeepOpenOnMoon) &&
                            (!global::GameNetworkManager.Instance.gameHasStarted || ServerConfiguration.Instance.Lobby.KeepOpen))
                        {
                            handshake.ReadDataFromClientBeforeJoining(reader);
                        }
                        else
                        {
                            handshake.SetError("Lobby is currently not joinable. Game has started.");
                        }
                    }
                    else
                    {
                        handshake.SetError("Missing AdvancedCompany mod.");
                        Plugin.Log.LogWarning("Client is missing AdvancedCompany!");
                    }
                }
            }
            catch (Exception x)
            {
                handshake.SetError("Unknown error");
                Plugin.Log.LogError("Unknown error while connecting:");
                Plugin.Log.LogError(x.ToString());
            }
        }

[D1GQ]

I wonder if we can do anything with SendConnectionRequest In NetworkConnectionManager.

[winstxnhdw]

Yeah, we'll have to patch the RPC methods directly for sure.