Python3.8

[martindemharter]

Hello everybody,

this script won't work on python3.8 onward anymore. The function platform.linux_distribution() was deprecated with python 3.5 and removed with 3.8. The function platform.uname() is not really helpful for CentOS/RedHat Distributions, so i went the route of /etc/os-release and parsing the relevant part.

It is tested and works for Python 3.6.9 (on Ubuntu 18.04.5) and Python 3.8.5 (on Ubuntu 20.04.1) as well as CentOS 8.2.2004 with Python 3.8.0.

[winem]

Hi,

thanks for the heads up. I'll fix this soon.

[martindemharter]

i already did a fix. just cannot open pull request.

[martindemharter]

This is basically what i did + removing import plaform:

def get_os():
    if os.name == 'posix':
        os_family = linux_distrib()
    else:
        print("Unsupported operating system.")
        sys.exit(3)
    return os_family

# checks for os-release file to extract os type. Fix for Python3.8 platform.linux_distribution() removal.
def linux_distrib():
    f = open("/etc/os-release")
    os_family = str(f.readline()) # read first line of file. there usually you find >NAME="Ubuntu"< or >NAME="CentOS Linux"<
    return os_family.split('\"')[1] # removing the >NAME=""< part

def main(args):
    os_family = get_os()
    if args.chk_resource.lower() == 'leapstatus':
        if 'Ubuntu' in os_family:
            timesyncd_monitoring = timedatectlStatus()
            resultToIcinga(timesyncd_monitoring)
        elif os_family == "Red Hat Enterprise Linux" or os_family == "CentOS Linux":
            chronyc_monitoring = chronycTracking()
            resultToIcinga(chronyc_monitoring)
        else:
            print('Unsupported operating system.')
            sys.exit(3)

[as149]

Hi,

an other simple Solution is to change the code as followed:

@@ -4,13 +4,13 @@
 import csv
 import io
 import os
-import platform
+import distro
 import socket
 import subprocess
 import sys

 def main(args):
-    os_family           = platform.linux_distribution()[0]
+    os_family           = distro.like()

     if args.daemon == 'chronyc':
         if args.resource == 'leap_status':

[vmpr]

I just also ran into that problem, can you fix that @winem ?