Skip to content

Conversation

@rubenfiszel
Copy link
Contributor

@rubenfiszel rubenfiszel commented Dec 3, 2025

🤖 I have created a release beep boop

1.589.1 (2025-12-03)

Bug Fixes

  • backend: fix broken cancel selection/all (752e43e)
  • wmill app generate-locks (#7288) (99b1ae2)

This PR was generated with Release Please. See documentation.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2025

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: f890721
Status: ✅  Deploy successful!
Preview URL: https://28a689e7.windmill.pages.dev
Branch Preview URL: https://release-please--branches--ma.windmill.pages.dev

View logs

@claude
Copy link
Contributor

claude bot commented Dec 3, 2025

Claude finished @rubenfiszel's task —— View job


Release 1.589.0 Review

Tasks

  • Read CHANGELOG.md changes
  • Review release notes structure
  • Analyze features and bug fixes included
  • Provide comprehensive feedback
  • Create reproduction instructions for testers

Overview

This is an automated release PR generated by release-please that bundles version 1.589.0 with 1 new feature and 3 bug fixes.

Code Quality Assessment

✅ Strengths

  • Clean changelog structure: Follows conventional commits format with proper categorization
  • Proper semantic versioning: Minor version bump (1.588.0 → 1.589.0) is appropriate for a feature addition
  • Good PR references: All changes properly linked to their source PRs/commits
  • Date stamping: Release properly dated (2025-12-03)

⚠️ Issues Found

CRITICAL: Duplicate Changelog Entry

The CHANGELOG.md file contains a duplicate entry for version 1.589.0 (lines 3-16 and 17-28). This appears to be a merge artifact from the release-please bot. The second duplicate is missing the CLI bug fix entry.

Location: CHANGELOG.md:3-28

Impact:

  • Confusing for users reading the changelog
  • Could cause issues with changelog parsers
  • Unprofessional appearance in release documentation

Recommendation: Remove the duplicate entry (lines 17-28) before merging this PR.

Release Content Analysis

Feature: Agent Workers Min Version Support (#7284)

Files changed: 5 files, +82/-26 lines

  • Backend enhancement for version control of agent workers
  • Includes OpenAPI spec updates
  • Adds periodic minimum version updates
  • Good error handling additions in windmill-common/src/error.rs

Potential concerns:

  • No documentation about what "min version" means for users
  • Should verify backward compatibility with existing agent workers

Bug Fix: CLI Apps Pushing Back-Compatibility (d3564a0)

Files changed: 2 CLI files

  • Improves handling of app synchronization in the CLI
  • Small, focused change (+9/-5 lines)

Bug Fix: Get Flow By ID Without Path (#7278)

Files changed: 5 files, +92/-56 lines

  • Significant refactoring in backend/windmill-api/src/flows.rs
  • Simplifies API by removing path requirement for flow ID lookups
  • Updates OpenAPI spec
  • Frontend adjustments in FlowHistoryInner component

Observation: This is a relatively large change for a bug fix. The refactoring improves the API ergonomics but should be tested thoroughly.

Bug Fix: Git Sync on Promotion Mode for Forks (#7276)

Files changed: 1 file (ee-repo-ref.txt)

  • Simple enterprise repository reference update
  • Minimal change, likely safe

Security Considerations

✅ No obvious security issues identified

  • No credential handling changes
  • No authentication/authorization modifications
  • Standard API endpoint updates with proper error handling

Performance Considerations

✅ No performance regressions expected

  • Agent worker version checking runs periodically (not on hot path)
  • Flow API changes simplify query logic (potential improvement)
  • CLI changes are client-side only

Testing Recommendations

To verify these changes work correctly, testers should navigate to the Windmill application and perform the following validations:

For Agent Workers Min Version Support: Access the Workers page from the workspace settings and verify that worker version information is displayed correctly. Check that any minimum version warnings or alerts appear when running workers with outdated versions. Test job execution on different worker versions to ensure the version checking doesn't block legitimate work.

For Flow ID Lookup Fix: Open the Flows section and select any existing flow. Navigate to the flow's history tab and verify that the flow version history loads without errors. Try accessing flows by their ID through the API or direct URL navigation without providing the path parameter, which should now work seamlessly.

For CLI Back-Compatibility: Use the Windmill CLI to push an app from an older workspace format to a newer server version. The operation should complete without errors and the app should render correctly in the app editor. Test both new app creation and updates to existing apps.

For Git Sync Fork Fix: In a forked workspace with promotion mode enabled, verify that git sync operations complete without attempting to sync promotion-mode repositories. Check the workspace settings under Git Sync to ensure the configuration respects the fork's promotion mode restrictions.

Final Recommendation

Action Required Before Merge: Remove the duplicate changelog entry (CHANGELOG.md lines 17-28) to ensure a clean, professional release.

Once the duplicate is removed, this release is ready to merge. The changes are well-structured and follow project conventions. The feature additions and bug fixes are appropriately scoped for a minor version release.


@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from bc6c5b8 to deecefe Compare December 3, 2025 18:07
@rubenfiszel rubenfiszel changed the title chore(main): release 1.589.0 chore(main): release 1.589.1 Dec 3, 2025
@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 04d8e5c to f890721 Compare December 3, 2025 19:11
@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 894ce0c to 9913e3b Compare December 3, 2025 19:16
@rubenfiszel rubenfiszel merged commit 0c74253 into main Dec 3, 2025
11 checks passed
@rubenfiszel rubenfiszel deleted the release-please--branches--main--components--windmill branch December 3, 2025 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
@rubenfiszel
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants