Testing ggplot classes

[teunbrand]

Hi Claus,

We've been reimplenting ggplot2's S3 classes as S7 classes and unfortunately, this affects one test in cowplot. Happy to send along a PR if that is quicker for you.
The issue is described in tidyverse/ggplot2#6498, where you're welcome to raise discussion.
The issue isn't with your packaged code, but with the unit tests found here:

cowplot/tests/testthat/test_ggdraw.R

Line 7 in 34819eb

expect_equal(methods::is(g), "gg")

You can test your code with the development version of ggplot2 by installing it as follows:

# install.packages("pak")
pak::pak("tidyverse/ggplot2")

We aim to release the new ggplot2 version in about 2 weeks, and it would be great if we didn't break cowplot. Hopefully this will inform you in a timely manner.

Best wishes,
Teun

[clauswilke]

No worries, I will fix this within the next few days.

[teunbrand]

Thanks for the speedy response Claus!

[clauswilke]

@teunbrand Just FYI, I'm encountering my own revdep issues that may require some delay (~2 weeks) until cowplot is submitted to CRAN. I'm probably not the only one in this situation. It would be helpful if you could factor this into your ggplot release schedule. The transition to S7 is sufficiently major that we probably need a bit more time than just 2 weeks from initial notification to having all packages ready for the new ggplot.

[teunbrand]

Yeah that is sensible. You can already consider the two weeks aspirational, because I haven't finished reaching out to everyone yet.

[clauswilke]

@teunbrand Updated cowplot is now on CRAN.

[teunbrand]

Great, thank you Claus!