build: Use PHP8 functions str_contains, str_starts_with and str_ends_with

For readability of the conditions

Change-Id: Ie14da92125a4288d22c093e6f2311402f8541615

Author: umherirrender

lib/Less/Autoloader.php

@@ -43,7 +43,7 @@ public static function unregister() {
 	 */
 	public static function loadClass( $className ) {
 		// handle only package classes
-		if ( strpos( $className, 'Less_' ) !== 0 ) {
+		if ( !str_starts_with( $className, 'Less_' ) ) {
 			return;
 		}
 

lib/Less/Cache.php

@@ -147,7 +147,7 @@ public static function Cache( &$less_files, $parser_options = [] ) {
 		foreach ( $less_files as $file_path => $uri_or_less ) {
 
 			// treat as less markup if there are newline characters
-			if ( strpos( $uri_or_less, "\n" ) !== false ) {
+			if ( str_contains( $uri_or_less, "\n" ) ) {
 				$parser->Parse( $uri_or_less );
 				continue;
 			}
@@ -236,7 +236,7 @@ public static function CleanCache( $dir = null ) {
 		foreach ( $files as $file ) {
 
 			// don't delete if the file wasn't created with less.php
-			if ( strpos( $file, self::$prefix ) !== 0 ) {
+			if ( !str_starts_with( $file, self::$prefix ) ) {
 				continue;
 			}
 

lib/Less/Parser.php

@@ -2495,7 +2495,7 @@ private function parseDeclaration() {
 				// Custom property values get permissive parsing
 				if ( is_array( $name ) && array_key_exists( 0, $name ) // to satisfy phan
 					&& $name[0] instanceof Less_Tree_Keyword
-					&& $name[0]->value && strpos( $name[0]->value, '--' ) === 0 ) {
+					&& $name[0]->value && str_starts_with( $name[0]->value, '--' ) ) {
 					$value = $this->parsePermissiveValue( [ ';', '}' ] );
 				} else {
 					// Try to store values as anonymous
@@ -3354,7 +3354,7 @@ public static function serializeVars( $vars ) {
 			if ( strval( $value ) === "" ) {
 				$value = '~""';
 			}
-			$s .= ( ( $name[0] === '@' ) ? '' : '@' ) . $name . ': ' . $value . ( ( substr( $value, -1 ) === ';' ) ? '' : ';' );
+			$s .= ( str_starts_with( $name, '@' ) ? '' : '@' ) . $name . ': ' . $value . ( str_ends_with( $value, ';' ) ? '' : ';' );
 		}
 
 		return $s;
@@ -3389,7 +3389,7 @@ public static function WinPath( $path ) {
 	}
 
 	public static function AbsPath( $path, $winPath = false ) {
-		if ( strpos( $path, '//' ) !== false && preg_match( '/^(https?:)?\/\//i', $path ) ) {
+		if ( str_contains( $path, '//' ) && preg_match( '/^(https?:)?\/\//i', $path ) ) {
 			return $winPath ? '' : false;
 		} else {
 			$path = realpath( $path );

lib/Less/SourceMap/Generator.php

@@ -178,12 +178,12 @@ protected function normalizeFilename( $filename ) {
 		$basePath = $this->getOption( 'sourceMapBasepath' );
 
 		// "Trim" the 'sourceMapBasepath' from the output filename.
-		if ( is_string( $basePath ) && strpos( $filename, $basePath ) === 0 ) {
+		if ( is_string( $basePath ) && str_starts_with( $filename, $basePath ) ) {
 			$filename = substr( $filename, strlen( $basePath ) );
 		}
 
 		// Remove extra leading path separators.
-		if ( strpos( $filename, '\\' ) === 0 || strpos( $filename, '/' ) === 0 ) {
+		if ( str_starts_with( $filename, '\\' ) || str_starts_with( $filename, '/' ) ) {
 			$filename = substr( $filename, 1 );
 		}
 

lib/Less/Tree/Call.php

@@ -147,7 +147,7 @@ public function compile( $env ) {
 
 					// Check if 'error evaluating function' is the start of the error message
 					// less.js does this by checking if line and column already set
-					if ( strpos( $e->getMessage(), 'error evaluating function' ) === 0 ) {
+					if ( str_starts_with( $e->getMessage(), 'error evaluating function' ) ) {
 						throw $e;
 					}
 

lib/Less/Tree/Url.php

@@ -61,7 +61,7 @@ public function compile( $env ) {
 		// Add cache buster if enabled
 		if ( Less_Parser::$options['urlArgs'] ) {
 			if ( !preg_match( '/^\s*data:/', $val->value ) ) {
-				$delimiter = strpos( $val->value, '?' ) === false ? '?' : '&';
+				$delimiter = !str_contains( $val->value, '?' ) ? '?' : '&';
 				$urlArgs = $delimiter . Less_Parser::$options['urlArgs'];
 				$hash_pos = strpos( $val->value, '#' );
 				if ( $hash_pos !== false ) {

test/compare.php

@@ -51,7 +51,7 @@ public function cli( $args ) {
 		foreach ( $args as $arg ) {
 			if ( $arg === '--override' ) {
 				$useOverride = true;
-			} elseif ( strpos( $arg, '--' ) === 0 ) {
+			} elseif ( str_starts_with( $arg, '--' ) ) {
 				$this->error( "Invalid option $arg" );
 			} elseif ( $fixtureDir === null ) {
 				// First non-option argument