Repository navigation
Fix #245 - Addressing new popover values - #247
theIDinside wants to merge 2 commits into
Conversation
Since the popover attribute got a new value, it's "find topmost popover ancestor" algorithm changed, and this PR attempts to address this in the Fullscreen API specification. After discussing with Luke Warlow we came to the conclusion that this is probably the intended change for the Fullscreen API spec.
|
|
||
| <pre class=link-defaults> | ||
| spec:html | ||
| type:dfn; text:allowed to use |
There was a problem hiding this comment.
FYI Reviewers: This is to fix the build as it's currently broken (see #246 for a standalone PR to fix that if that's preferable)
| spec:html | ||
| type:dfn; text:allowed to use | ||
| type:dfn; text:showing hint popover list | ||
| type:dfn; text:showing auto popover list |
There was a problem hiding this comment.
These aren't currently exported so are manually added here. PR to export them: whatwg/html#11140
There was a problem hiding this comment.
Probably just remove these from this PR then, right?
Nvm :P
There was a problem hiding this comment.
Once that gets merged yeah you should be able to remove these, useful to keep them for now so the preview works
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
This seems to match Chromium's implementation so I'll go ahead and approve it in the interest of progress / matching reality.
I'll comment on whatwg/html#11140 what we could do differently to use a slightly higher level abstraction.
|
I guess a test is needed for this, testing the interaction of |
|
A test is needed, but we also can't merge this until the HTML integration situation has an agreed upon solution. |
|
@jakearchibald's refactor seems to have sorted this out. |
4 participants
Since the popover attribute got a new value, it's
"find topmost popover ancestor" algorithm changed, and this PR attempts to address this in the Fullscreen API specification.
After discussing with @lukewarlow we came to the conclusion that this is probably the intended change for the Fullscreen API spec.
This addresses #245
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff