Cumulative changes #24
Conversation
Merge upstream changes into local
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 75.00% 74.91% -0.09%
==========================================
Files 6 6
Lines 284 279 -5
==========================================
- Hits 213 209 -4
+ Misses 71 70 -1 ☔ View full report in Codecov by Sentry. |
wezm
left a comment
wezm
left a comment
There was a problem hiding this comment.
Thanks for this. Left a few comments.
| const ROWS: u16 = 212; | ||
| const COLS: u8 = 104; | ||
|
|
||
| // More documentation for LUTs can be found at https://github.com/pimoroni/inky/blob/master/library/inky/inky.py#L95 |
There was a problem hiding this comment.
Good idea but can you make this a permalink (press y on the GitHub page) so that if the code changes the link will still point at the right thing.
| // This is indeed a copy of Pimoroni's Inky LUTs. Saved here for reference. | ||
| // They license it out under the MIT license. Refer to LICENSE-MIT for more details. | ||
|
|
||
| // More documentation for LUTs can be found at https://github.com/pimoroni/inky/blob/master/library/inky/inky.py#L95 |
| @@ -0,0 +1,49 @@ | |||
| // This is indeed a copy of Pimoroni's Inky LUTs. Saved here for reference. | |||
| // They license it out under the MIT license. Refer to LICENSE-MIT for more details. | |||
There was a problem hiding this comment.
We should credit Pimoroni in the LICENSE, please add
Copyright (c) 2018 Pimoroni Ltd.
to the top of LICENSE-MIT
|
|
||
| // More documentation for LUTs can be found at https://github.com/pimoroni/inky/blob/master/library/inky/inky.py#L95 | ||
| #[rustfmt::skip] | ||
| const LUT: [u8; 70] = [ |
There was a problem hiding this comment.
Can the example be updated to use the LUTs add to the crate?
3 participants
Summary of changes