Skip to content

How to preserve missing values in diff #28

@GFoley83

Description

@GFoley83

I'm confused about how to preserve missing values from when diffing two objects.

Take for example these two json blocks:

{
  "Name": "John",
  "Age": 34,
  "Origin": "Scotland",  
  "Pets": [
    {
      "Type": "Cat",
      "Name": "MooMoo",
      "Age": 3.4
    },
    {
      "Type": "Squirrel",
      "Name": "Sandy",
      "Age": 7
    }
  ]
}
{
  "Origin": "Ireland"
}

When I run a patch, I would like to end up with:

{
  "Name": "John",
  "Age": 34,
  "Origin": "Ireland",   // UPDATED HERE  
  "Pets": [
    {
      "Type": "Cat",
      "Name": "MooMoo",
      "Age": 3.4
    },
    {
      "Type": "Squirrel",
      "Name": "Sandy",
      "Age": 7
    }
  ]
}

Basically all the missing values are preserved and only the values that conflict are updated, but I can seem to achieve this.

Activity

weichch

weichch commented on Jul 5, 2022

@weichch
Owner

I think your example is merge patch (e.g. JSON Merge Patch) which is currently not supported. The patch document generated through diffing is equivalent to JSON Patch, which contains all operations required to fully transform JSON A to B. If you use the Live Demo provided by jsondiffpatch, you can visualize the document/operations.

I say currently not supported because I did plan to add some support for it at some stage.

jannikbuschke

jannikbuschke commented on Feb 23, 2023

@jannikbuschke

It would be awesome to have this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @GFoley83@weichch@jannikbuschke

        Issue actions

          How to preserve missing values in diff · Issue #28 · weichch/system-text-json-jsondiffpatch