Skip to content

Commit a80c36c

Browse files
SuaYooikreymer
authored andcommitted
clean up render methods
1 parent b059559 commit a80c36c

File tree

1 file changed

+41
-37
lines changed
  • frontend/src/pages/org/collection-detail

1 file changed

+41
-37
lines changed

frontend/src/pages/org/collection-detail/dedupe.ts

Lines changed: 41 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -114,41 +114,7 @@ export class CollectionDetailDedupe extends BtrixElement {
114114
if (!this.collection) return;
115115

116116
if (this.collection.hasDedupeIndex) {
117-
return html`
118-
<div
119-
class="mb-3 flex items-center justify-between gap-3 rounded-lg border bg-neutral-50 p-3"
120-
>
121-
<div class="flex items-center gap-2">
122-
<label for="view" class="whitespace-nowrap text-neutral-500"
123-
>${msg("View:")}</label
124-
>
125-
<sl-radio-group
126-
id="view"
127-
size="small"
128-
value=${this.view.value.crawlsView || DEFAULT_CRAWLS_VIEW}
129-
@sl-change=${(e: SlChangeEvent) => {
130-
this.view.setValue({
131-
crawlsView: (e.target as SlRadioGroup).value as CrawlsView,
132-
});
133-
}}
134-
>
135-
<sl-radio-button pill value=${DEFAULT_CRAWLS_VIEW}>
136-
${msg("Crawl Workflows")}
137-
</sl-radio-button>
138-
<sl-radio-button pill value=${CrawlsView.Crawls}>
139-
${msg("Indexed Crawls")}
140-
</sl-radio-button>
141-
</sl-radio-group>
142-
</div>
143-
</div>
144-
145-
<div class="mx-2">
146-
${choose(this.view.value.crawlsView, [
147-
[CrawlsView.Workflows, this.renderDedupeWorkflows],
148-
[CrawlsView.Crawls, this.renderDedupeCrawls],
149-
])}
150-
</div>
151-
`;
117+
return this.renderCrawls();
152118
}
153119

154120
return panelBody({
@@ -171,7 +137,45 @@ export class CollectionDetailDedupe extends BtrixElement {
171137
});
172138
}
173139

174-
private readonly renderDedupeCrawls = () => {
140+
private renderCrawls() {
141+
return html`
142+
<div
143+
class="mb-3 flex items-center justify-between gap-3 rounded-lg border bg-neutral-50 p-3"
144+
>
145+
<div class="flex items-center gap-2">
146+
<label for="view" class="whitespace-nowrap text-neutral-500"
147+
>${msg("View:")}</label
148+
>
149+
<sl-radio-group
150+
id="view"
151+
size="small"
152+
value=${this.view.value.crawlsView || DEFAULT_CRAWLS_VIEW}
153+
@sl-change=${(e: SlChangeEvent) => {
154+
this.view.setValue({
155+
crawlsView: (e.target as SlRadioGroup).value as CrawlsView,
156+
});
157+
}}
158+
>
159+
<sl-radio-button pill value=${DEFAULT_CRAWLS_VIEW}>
160+
${msg("Crawl Workflows")}
161+
</sl-radio-button>
162+
<sl-radio-button pill value=${CrawlsView.Crawls}>
163+
${msg("Indexed Crawls")}
164+
</sl-radio-button>
165+
</sl-radio-group>
166+
</div>
167+
</div>
168+
169+
<div class="mx-2">
170+
${choose(this.view.value.crawlsView, [
171+
[CrawlsView.Workflows, this.renderWorkflowList],
172+
[CrawlsView.Crawls, this.renderCrawlList],
173+
])}
174+
</div>
175+
`;
176+
}
177+
178+
private readonly renderCrawlList = () => {
175179
const loading = () => html`
176180
<sl-skeleton effect="sheen" class="h-9"></sl-skeleton>
177181
`;
@@ -221,7 +225,7 @@ export class CollectionDetailDedupe extends BtrixElement {
221225
})}`;
222226
};
223227

224-
private readonly renderDedupeWorkflows = () => {
228+
private readonly renderWorkflowList = () => {
225229
const loading = () =>
226230
html`<sl-skeleton effect="sheen" class="h-10"></sl-skeleton>`;
227231
return html`${this.dedupeWorkflowsTask.render({

0 commit comments

Comments
 (0)