Skip to content

Commit 8c8fd6b

Browse files
authored
remove --disable-component-update flag, fixes shields not working (#915)
should fix main cause of slow down in #913 deps: update to brave 1.84.139, puppeteer 24.30.0 bump to 1.9.1
1 parent bb11147 commit 8c8fd6b

File tree

4 files changed

+39
-39
lines changed

4 files changed

+39
-39
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ARG BROWSER_VERSION=1.84.135
1+
ARG BROWSER_VERSION=1.84.139
22
ARG BROWSER_IMAGE_BASE=webrecorder/browsertrix-browser-base:brave-${BROWSER_VERSION}
33

44
FROM ${BROWSER_IMAGE_BASE}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "browsertrix-crawler",
3-
"version": "1.9.0",
3+
"version": "1.9.1",
44
"main": "browsertrix-crawler",
55
"type": "module",
66
"repository": "https://github.com/webrecorder/browsertrix-crawler",
@@ -33,7 +33,7 @@
3333
"p-queue": "^7.3.4",
3434
"pixelmatch": "^5.3.0",
3535
"pngjs": "^7.0.0",
36-
"puppeteer-core": "^24.22.0",
36+
"puppeteer-core": "^24.30.0",
3737
"sax": "^1.3.0",
3838
"sharp": "^0.32.6",
3939
"tsc": "^2.0.4",

src/util/browser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ export const defaultArgs = [
729729
"--disable-breakpad",
730730
"--disable-client-side-phishing-detection",
731731
"--disable-component-extensions-with-background-pages",
732-
"--disable-component-update", // Avoids unneeded network activity after startup.
732+
//"--disable-component-update", // now required for chrome/brave
733733
"--no-default-browser-check",
734734
"--disable-default-apps",
735735
"--disable-dev-shm-usage",

yarn.lock

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -772,17 +772,17 @@
772772
tslib "^2.7.0"
773773
tsyringe "^4.8.0"
774774

775-
"@puppeteer/[email protected].10":
776-
version "2.10.10"
777-
resolved "https://registry.yarnpkg.com/@puppeteer/browsers/-/browsers-2.10.10.tgz#f806f92d966918c931fb9c48052eba2db848beaa"
778-
integrity sha512-3ZG500+ZeLql8rE0hjfhkycJjDj0pI/btEh3L9IkWUYcOrgP0xCNRq3HbtbqOPbvDhFaAWD88pDFtlLv8ns8gA==
775+
"@puppeteer/[email protected].13":
776+
version "2.10.13"
777+
resolved "https://registry.yarnpkg.com/@puppeteer/browsers/-/browsers-2.10.13.tgz#42c8b7df14e992f311ca9dca5fed3f0c2182fd17"
778+
integrity sha512-a9Ruw3j3qlnB5a/zHRTkruppynxqaeE4H9WNj5eYGRWqw0ZauZ23f4W2ARf3hghF5doozyD+CRtt7XSYuYRI/Q==
779779
dependencies:
780780
debug "^4.4.3"
781781
extract-zip "^2.0.1"
782782
progress "^2.0.3"
783783
proxy-agent "^6.5.0"
784-
semver "^7.7.2"
785-
tar-fs "^3.1.0"
784+
semver "^7.7.3"
785+
tar-fs "^3.1.1"
786786
yargs "^17.7.2"
787787

788788
"@puppeteer/[email protected]":
@@ -1715,18 +1715,18 @@ chrome-launcher@^1.1.2:
17151715
is-wsl "^2.2.0"
17161716
lighthouse-logger "^2.0.1"
17171717

1718-
chromium-bidi@2.1.2:
1719-
version "2.1.2"
1720-
resolved "https://registry.yarnpkg.com/chromium-bidi/-/chromium-bidi-2.1.2.tgz#b0710279f993128d4e0b41c892209ea093217d97"
1721-
integrity sha512-vtRWBK2uImo5/W2oG6/cDkkHSm+2t6VHgnj+Rcwhb0pP74OoUb4GipyRX/T/y39gYQPhioP0DPShn+A7P6CHNw==
1718+
chromium-bidi@11.0.0:
1719+
version "11.0.0"
1720+
resolved "https://registry.yarnpkg.com/chromium-bidi/-/chromium-bidi-11.0.0.tgz#193433d0722095abca0cada2fa0c5111b447bea3"
1721+
integrity sha512-cM3DI+OOb89T3wO8cpPSro80Q9eKYJ7hGVXoGS3GkDPxnYSqiv+6xwpIf6XERyJ9Tdsl09hmNmY94BkgZdVekw==
17221722
dependencies:
17231723
mitt "^3.0.1"
17241724
zod "^3.24.1"
17251725

1726-
chromium-bidi@8.0.0:
1727-
version "8.0.0"
1728-
resolved "https://registry.yarnpkg.com/chromium-bidi/-/chromium-bidi-8.0.0.tgz#d73c9beed40317adf2bcfeb9a47087003cd467ec"
1729-
integrity sha512-d1VmE0FD7lxZQHzcDUCKZSNRtRwISXDsdg4HjdTR5+Ll5nQ/vzU12JeNmupD6VWffrPSlrnGhEWlLESKH3VO+g==
1726+
chromium-bidi@2.1.2:
1727+
version "2.1.2"
1728+
resolved "https://registry.yarnpkg.com/chromium-bidi/-/chromium-bidi-2.1.2.tgz#b0710279f993128d4e0b41c892209ea093217d97"
1729+
integrity sha512-vtRWBK2uImo5/W2oG6/cDkkHSm+2t6VHgnj+Rcwhb0pP74OoUb4GipyRX/T/y39gYQPhioP0DPShn+A7P6CHNw==
17301730
dependencies:
17311731
mitt "^3.0.1"
17321732
zod "^3.24.1"
@@ -2059,10 +2059,10 @@ [email protected]:
20592059
resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1436416.tgz#ce8af8a210b8bcac83c5c8f095b9f977a9570df0"
20602060
integrity sha512-iGLhz2WOrlBLcTcoVsFy5dPPUqILG6cc8MITYd5lV6i38gWG14bMXRH/d8G5KITrWHBnbsOnWHfc9Qs4/jej9Q==
20612061

2062-
2063-
version "0.0.1495869"
2064-
resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1495869.tgz#f68daef77a48d5dcbcdd55dbfa3265a51989c91b"
2065-
integrity sha512-i+bkd9UYFis40RcnkW7XrOprCujXRAHg62IVh/Ah3G8MmNXpCGt1m0dTFhSdx/AVs8XEMbdOGRwdkR1Bcta8AA==
2062+
2063+
version "0.0.1521046"
2064+
resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1521046.tgz#918e6175ea83100fefcb2b78779f15a77aa8a41b"
2065+
integrity sha512-vhE6eymDQSKWUXwwA37NtTTVEzjtGVfDr3pRbsWEQ5onH/Snp2c+2xZHWJJawG/0hCCJLRGt4xVtEVUVILol4w==
20662066

20672067
diff-sequences@^29.6.3:
20682068
version "29.6.3"
@@ -4567,17 +4567,17 @@ [email protected], puppeteer-core@^24.4.0:
45674567
typed-query-selector "^2.12.0"
45684568
ws "^8.18.1"
45694569

4570-
puppeteer-core@^24.22.0:
4571-
version "24.22.0"
4572-
resolved "https://registry.yarnpkg.com/puppeteer-core/-/puppeteer-core-24.22.0.tgz#4d576b1a2b7699c088d3f0e843c32d81df82c3a6"
4573-
integrity sha512-oUeWlIg0pMz8YM5pu0uqakM+cCyYyXkHBxx9di9OUELu9X9+AYrNGGRLK9tNME3WfN3JGGqQIH3b4/E9LGek/w==
4570+
puppeteer-core@^24.30.0:
4571+
version "24.30.0"
4572+
resolved "https://registry.yarnpkg.com/puppeteer-core/-/puppeteer-core-24.30.0.tgz#7d0d15ce6aee4f1aa8a8f046bf0198f025ee6c81"
4573+
integrity sha512-2S3Smy0t0W4wJnNvDe7W0bE7wDmZjfZ3ljfMgJd6hn2Hq/f0jgN+x9PULZo2U3fu5UUIJ+JP8cNUGllu8P91Pg==
45744574
dependencies:
4575-
"@puppeteer/browsers" "2.10.10"
4576-
chromium-bidi "8.0.0"
4575+
"@puppeteer/browsers" "2.10.13"
4576+
chromium-bidi "11.0.0"
45774577
debug "^4.4.3"
4578-
devtools-protocol "0.0.1495869"
4578+
devtools-protocol "0.0.1521046"
45794579
typed-query-selector "^2.12.0"
4580-
webdriver-bidi-protocol "0.2.11"
4580+
webdriver-bidi-protocol "0.3.8"
45814581
ws "^8.18.3"
45824582

45834583
puppeteer@^24.4.0:
@@ -4853,10 +4853,10 @@ semver@^7.7.1:
48534853
resolved "https://registry.yarnpkg.com/semver/-/semver-7.7.1.tgz#abd5098d82b18c6c81f6074ff2647fd3e7220c9f"
48544854
integrity sha512-hlq8tAfn0m/61p4BVRcPzIGr6LKiMwo4VM6dGi6pt4qcRkmNzTcWq6eCEjEh+qXjkMDvPlOFFSGwQjoEa6gyMA==
48554855

4856-
semver@^7.7.2:
4857-
version "7.7.2"
4858-
resolved "https://registry.yarnpkg.com/semver/-/semver-7.7.2.tgz#67d99fdcd35cec21e6f8b87a7fd515a33f982b58"
4859-
integrity sha512-RF0Fw+rO5AMf9MAyaRXI4AV0Ulj5lMHqVxxdSgiVbixSCXoEmmX/jk0CuJw4+3SqroYO9VoUh+HcuJivvtJemA==
4856+
semver@^7.7.3:
4857+
version "7.7.3"
4858+
resolved "https://registry.yarnpkg.com/semver/-/semver-7.7.3.tgz#4b5f4143d007633a8dc671cd0a6ef9147b8bb946"
4859+
integrity sha512-SdsKMrI9TdgjdweUSR9MweHA4EJ8YxHn8DFaDisvhVlUOe4BF1tLD7GAj0lIqWVl+dPb/rExr0Btby5loQm20Q==
48604860

48614861
set-function-length@^1.2.1:
48624862
version "1.2.2"
@@ -5220,7 +5220,7 @@ tar-fs@^3.0.8:
52205220
bare-fs "^4.0.1"
52215221
bare-path "^3.0.0"
52225222

5223-
tar-fs@^3.1.0:
5223+
tar-fs@^3.1.1:
52245224
version "3.1.1"
52255225
resolved "https://registry.yarnpkg.com/tar-fs/-/tar-fs-3.1.1.tgz#4f164e59fb60f103d472360731e8c6bb4a7fe9ef"
52265226
integrity sha512-LZA0oaPOc2fVo82Txf3gw+AkEd38szODlptMYejQUhndHMLQ9M059uXR+AfS7DNo0NpINvSqDsvyaCrBVkptWg==
@@ -5585,10 +5585,10 @@ web-encoding@^1.1.5:
55855585
optionalDependencies:
55865586
"@zxing/text-encoding" "0.9.0"
55875587

5588-
webdriver-bidi-protocol@0.2.11:
5589-
version "0.2.11"
5590-
resolved "https://registry.yarnpkg.com/webdriver-bidi-protocol/-/webdriver-bidi-protocol-0.2.11.tgz#dba18d9b0a33aed33fab272dbd6e42411ac753cc"
5591-
integrity sha512-Y9E1/oi4XMxcR8AT0ZC4OvYntl34SPgwjmELH+owjBr0korAX4jKgZULBWILGCVGdVCQ0dodTToIETozhG8zvA==
5588+
webdriver-bidi-protocol@0.3.8:
5589+
version "0.3.8"
5590+
resolved "https://registry.yarnpkg.com/webdriver-bidi-protocol/-/webdriver-bidi-protocol-0.3.8.tgz#9c822b2647fd16d22b1b6fd730d4a3b863c93b93"
5591+
integrity sha512-21Yi2GhGntMc671vNBCjiAeEVknXjVRoyu+k+9xOMShu+ZQfpGQwnBqbNz/Sv4GXZ6JmutlPAi2nIJcrymAWuQ==
55925592

55935593
whatwg-encoding@^2.0.0:
55945594
version "2.0.0"

0 commit comments

Comments
 (0)