Skip to content

Commit 0ecd680

Browse files
committed
electron app: ensure new 'waiting for reload' message not shown in preview mode, cleared in electron app when recording started
1 parent c7cb09f commit 0ecd680

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

src/popup.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,9 @@ class RecPopup extends LitElement
107107
switch (message.type) {
108108
case "status":
109109
this.recording = message.recording;
110-
this.waitingForStart = !message.firstPageStarted;
110+
if (this.waitingForStart && message.firstPageStarted) {
111+
this.waitingForStart = false;
112+
}
111113
this.status = message;
112114
if (message.pageUrl) {
113115
this.pageUrl = message.pageUrl;

src/recorder.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -553,10 +553,6 @@ class Recorder {
553553
this.fullCommit(reqresp, sessions);
554554
}
555555

556-
if (!this.firstPageStarted) {
557-
this.initFirstPage();
558-
}
559-
560556
return true;
561557
}
562558

@@ -586,6 +582,10 @@ class Recorder {
586582
this._fetchUrls.clear();
587583

588584
this._pdfTextDone = null;
585+
586+
if (!this.firstPageStarted) {
587+
this.initFirstPage();
588+
}
589589
}
590590

591591
loadFavIcon(favIconUrl, sessions) {

wr-ext/bg.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)