Switch from XML-based to PHP-based service configuration (#42)

XML-based service configuration has been deprecated since
symfony/symfony#60568 and will no longer be
supported in Symfony 8.0.

See also
https://symfony.com/blog/new-in-symfony-7-4-deprecated-xml-configuration.

In order for ComposerRequireChecker to recognise where the functions
come from, we have to import them explicitly. At the same time,
PHP-CS-Fixer must not remove the import, which is actually superfluous.

X-Ref GromNaN/symfony-config-xml-to-php#29,
maglnet/ComposerRequireChecker#193 (comment)

Author: mpdude

.php-cs-fixer.dist.php

@@ -25,5 +25,6 @@
             ->notPath('var/cache')
             ->notPath('vendor/')
             ->notPath('tests/Fixtures/cache')
+            ->notPath('src/Resources/config')
     )
 ;

src/DependencyInjection/WebfactoryShortcodeExtension.php

@@ -6,7 +6,7 @@
 use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Extension\Extension;
-use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
+use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
 
 /**
  * Loads the bundle configuration.
@@ -15,9 +15,9 @@ final class WebfactoryShortcodeExtension extends Extension
 {
     public function load(array $configs, ContainerBuilder $container): void
     {
-        $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
-        $loader->load('shortcodes.xml');
-        $loader->load('guide.xml');
+        $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader->load('shortcodes.php');
+        $loader->load('guide.php');
 
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);

src/Resources/config/guide.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use function Symfony\Component\DependencyInjection\Loader\Configurator\inline_service;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function(ContainerConfigurator $container) {
+    $services = $container->services();
+    $parameters = $container->parameters();
+
+    $services->defaults()
+        ->autowire()
+        ->autoconfigure();
+
+    $services->set(\Webfactory\ShortcodeBundle\Controller\GuideController::class)
+        ->args([
+            '',
+            service('twig'),
+        ])
+        ->tag('controller.service_arguments');
+};

src/Resources/config/guide.xml

@@ -0,0 +1,78 @@
+<?php
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use function Symfony\Component\DependencyInjection\Loader\Configurator\inline_service;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function(ContainerConfigurator $container) {
+    $services = $container->services();
+    $parameters = $container->parameters();
+
+    $services->defaults()
+        ->private();
+
+    $services->set(\Thunder\Shortcode\HandlerContainer\HandlerContainer::class);
+
+    $services->set('webfactory_shortcode.regular_parser', \Thunder\Shortcode\Parser\RegularParser::class);
+
+    $services->set('webfactory_shortcode.regex_parser', \Thunder\Shortcode\Parser\RegexParser::class);
+
+    $services->set(\Webfactory\ShortcodeBundle\Factory\ProcessorFactory::class)
+        ->args([
+            service('webfactory_shortcode.parser'),
+            service(\Thunder\Shortcode\HandlerContainer\HandlerContainer::class),
+            service(\Thunder\Shortcode\EventContainer\EventContainer::class),
+            '%webfactory_shortcode.recursion_depth%',
+            '%webfactory_shortcode.max_iterations%',
+        ]);
+
+    $services->set(\Thunder\Shortcode\Processor\Processor::class)
+        ->public()
+        ->factory([service(\Webfactory\ShortcodeBundle\Factory\ProcessorFactory::class), 'create']);
+
+    $services->set(\Thunder\Shortcode\EventContainer\EventContainer::class)
+        ->call('addListener', [
+            \Thunder\Shortcode\Events::REPLACE_SHORTCODES,
+            inline_service(\Webfactory\ShortcodeBundle\Handler\RemoveWrappingParagraphElementsEventHandler::class),
+        ]);
+
+    $services->set('Webfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler.esi', \Webfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler::class)
+        ->abstract()
+        ->lazy()
+        ->args([
+            service('fragment.handler'),
+            '',
+            'esi',
+            service('request_stack'),
+            service('logger')->nullOnInvalid(),
+        ])
+        ->tag('monolog.logger', ['channel' => 'shortcode']);
+
+    $services->alias('webfactory.shortcode.embed_esi_for_shortcode_handler', 'Webfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler.esi');
+
+    $services->set('Webfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler.inline', \Webfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler::class)
+        ->abstract()
+        ->lazy()
+        ->args([
+            service('fragment.handler'),
+            '',
+            'inline',
+            service('request_stack'),
+            service('logger')->nullOnInvalid(),
+        ])
+        ->tag('monolog.logger', ['channel' => 'shortcode']);
+
+    $services->alias('webfactory.shortcode.embed_inline_for_shortcode_handler', 'Webfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler.inline');
+
+    $services->set(\Webfactory\ShortcodeBundle\Twig\ShortcodeExtension::class, \Webfactory\ShortcodeBundle\Twig\ShortcodeExtension::class)
+        ->args([service(\Thunder\Shortcode\Processor\Processor::class)])
+        ->tag('twig.extension');
+
+    $services->set(\Webfactory\ShortcodeBundle\Test\ShortcodeDefinitionTestHelper::class)
+        ->public()
+        ->args([
+            service('controller_resolver'),
+            service(\Thunder\Shortcode\HandlerContainer\HandlerContainer::class),
+        ]);
+};