Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Commit f5aaef3

Browse files
committed
Revert "warning: introduce a delay between add() and kernel_add()"
This reverts commit 405d3ee.
1 parent 2d5462f commit f5aaef3

File tree

6 files changed

+0
-25
lines changed

6 files changed

+0
-25
lines changed

src/conf_mode/vpp_interfaces_bonding.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
1818

1919
import os
20-
import time
2120

2221
from vyos.config import Config
2322
from vyos.configdict import leaf_node_changed
@@ -193,10 +192,6 @@ def apply(config):
193192
state = 'up' if 'disable' not in config else 'down'
194193

195194
i = BondInterface(ifname, mode, lb, mac, kernel_interface, state)
196-
# Introduce a delay to address instability in the VPP API, which may fail to create the LCP
197-
# or establish a connection. This should be reviewed and resolved in future releases.
198-
time.sleep(2)
199-
200195
i.add()
201196
# Add members to bond
202197
if members:

src/conf_mode/vpp_interfaces_geneve.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
1818

1919
import os
20-
import time
2120

2221
from vyos import ConfigError
2322

@@ -165,9 +164,6 @@ def apply(config):
165164

166165
# Add kernel-interface (LCP) if interface is not exist
167166
if 'kernel_interface' in config and not is_interface(kernel_interface):
168-
# Introduce a delay to address instability in the VPP API, which may fail to create the LCP
169-
# or establish a connection. This should be reviewed and resolved in future releases.
170-
time.sleep(2)
171167
i.kernel_add()
172168

173169
call_dependents()

src/conf_mode/vpp_interfaces_gre.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
1818

1919
import os
20-
import time
2120

2221
from vyos import ConfigError
2322

@@ -175,9 +174,6 @@ def apply(config):
175174

176175
# Add kernel-interface (LCP) if interface is not exist
177176
if 'kernel_interface' in config and not is_interface(kernel_interface):
178-
# Introduce a delay to address instability in the VPP API, which may fail to create the LCP
179-
# or establish a connection. This should be reviewed and resolved in future releases.
180-
time.sleep(2)
181177
i.kernel_add()
182178

183179
call_dependents()

src/conf_mode/vpp_interfaces_ipip.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
1818

1919
import os
20-
import time
2120

2221
from vyos import ConfigError
2322

@@ -164,9 +163,6 @@ def apply(config):
164163
i.add()
165164

166165
if 'kernel_interface' in config:
167-
# Introduce a delay to address instability in the VPP API, which may fail to create the LCP
168-
# or establish a connection. This should be reviewed and resolved in future releases.
169-
time.sleep(2)
170166
i.kernel_add()
171167

172168
call_dependents()

src/conf_mode/vpp_interfaces_loopback.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
1818

1919
import os
20-
import time
2120

2221
from vyos import ConfigError
2322

@@ -136,9 +135,6 @@ def apply(config):
136135

137136
# Add kernel-interface (LCP) if interface is not exist
138137
if 'kernel_interface' in config and not is_interface(kernel_interface):
139-
# Introduce a delay to address instability in the VPP API, which may fail to create the LCP
140-
# or establish a connection. This should be reviewed and resolved in future releases.
141-
time.sleep(2)
142138
i.kernel_add()
143139

144140
call_dependents()

src/conf_mode/vpp_interfaces_vxlan.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
1818

1919
import os
20-
import time
2120

2221
from vyos import ConfigError
2322

@@ -171,9 +170,6 @@ def apply(config):
171170

172171
# Add kernel-interface (LCP) if interface is not exist
173172
if 'kernel_interface' in config and not is_interface(kernel_interface):
174-
# Introduce a delay to address instability in the VPP API, which may fail to create the LCP
175-
# or establish a connection. This should be reviewed and resolved in future releases.
176-
time.sleep(2)
177173
i.kernel_add()
178174

179175
call_dependents()

0 commit comments

Comments
 (0)