fix(typescript-plugin): prefer non-warning completion entry

Author: johnsoncodehk

packages/language-server/tests/completions.spec.ts

@@ -1,4 +1,5 @@
 import type { TextDocument } from '@volar/language-server';
+import * as path from 'node:path';
 import { afterEach, expect, test } from 'vitest';
 import { URI } from 'vscode-uri';
 import { getLanguageServer, testWorkspacePath } from './server.js';
@@ -867,6 +868,35 @@ test('Auto insert defines', async () => {
 	`);
 });
 
+test('#5847', async () => {
+	await prepareDocument(
+		'tsconfigProject/fixture.ts',
+		'typescript',
+		`export function testFn() { console.log('testFn'); }`,
+	);
+	expect(
+		await requestCompletionItemToTsServer(
+			'tsconfigProject/fixture.vue',
+			'vue',
+			`
+			<script setup></script>
+
+			<template>{{ testFn| }}</template>
+			`,
+			'testFn',
+		),
+	).toMatchInlineSnapshot(`
+		{
+		  "hasAction": true,
+		  "kind": "function",
+		  "kindModifiers": "export",
+		  "name": "testFn",
+		  "sortText": "16",
+		  "source": "tsconfigProject/fixture",
+		}
+	`);
+});
+
 const openedDocuments: TextDocument[] = [];
 
 afterEach(async () => {
@@ -918,6 +948,8 @@ async function requestCompletionItemToTsServer(
 	const completions = await requestCompletionListToTsServer(fileName, languageId, content);
 	let completion = completions.find((item: any) => item.name === itemLabel);
 	expect(completion).toBeDefined();
+	delete completion.data;
+	completion.source &&= path.relative(testWorkspacePath, completion.source);
 	return completion!;
 }
 

packages/typescript-plugin/lib/common.ts

@@ -96,7 +96,7 @@ export function preprocessLanguageService(
 	languageService.getCompletionsAtPosition = (fileName, position, preferences, formatOptions) => {
 		let result = getCompletionsAtPosition(fileName, position, preferences, formatOptions);
 		const language = getLanguage();
-		if (language) {
+		if (language && result) {
 			const [serviceScript, targetScript, sourceScript] = getServiceScript(language, fileName);
 			if (serviceScript && sourceScript?.generated?.root instanceof VueVirtualCode) {
 				for (
@@ -118,10 +118,20 @@ export function preprocessLanguageService(
 					if (generatedOffset2 !== undefined) {
 						const completion2 = getCompletionsAtPosition(targetScript.id, generatedOffset2, preferences, formatOptions);
 						if (completion2) {
-							const existingNames = new Set(result?.entries.map(entry => entry.name));
+							const nameToIndex = new Map(result.entries.map((entry, index) => [entry.name, index]));
 							for (const entry of completion2.entries) {
-								if (!existingNames.has(entry.name)) {
-									result?.entries.push(entry);
+								if (entry.kind === 'warning') {
+									continue;
+								}
+								if (nameToIndex.has(entry.name)) {
+									const index = nameToIndex.get(entry.name)!;
+									const existingEntry = result.entries[index]!;
+									if (existingEntry.kind === 'warning') {
+										result.entries[index] = entry;
+									}
+								}
+								else {
+									result.entries.push(entry);
 								}
 							}
 						}