feat: add response status code in attributes

daniyelnnr · daniyelnnr · commit d2943e19c8df · 2025-10-07T22:30:50.000-03:00
This change adds status code as an attribute for some metrics like request timings and responses sizes
diff --git a/src/service/metrics/otelRequestMetricsMiddleware.ts b/src/service/metrics/otelRequestMetricsMiddleware.ts
@@ -52,7 +52,10 @@ export const addOtelRequestMetricsMiddleware = () => {
       if (responseLength && instruments) {
         instruments.responseSizes.record(
           responseLength,
-          { [RequestsMetricLabels.REQUEST_HANDLER]: ctx.requestHandlerName }
+          {
+            [RequestsMetricLabels.REQUEST_HANDLER]: ctx.requestHandlerName,
+            [RequestsMetricLabels.STATUS_CODE]: ctx.response.status,
+          }
         )
       }
 
@@ -72,6 +75,7 @@ export const addOtelRequestMetricsMiddleware = () => {
             hrToMillisFloat(process.hrtime(start)),
             {
               [RequestsMetricLabels.REQUEST_HANDLER]: ctx.requestHandlerName,
+              [RequestsMetricLabels.STATUS_CODE]: ctx.response.status,
             }
           )
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,10 @@ export const addOtelRequestMetricsMiddleware = () => {`
`52`	`52`	`if (responseLength && instruments) {`
`53`	`53`	`instruments.responseSizes.record(`
`54`	`54`	`responseLength,`
`55`		`- { [RequestsMetricLabels.REQUEST_HANDLER]: ctx.requestHandlerName }`
	`55`	`+ {`
	`56`	`+ [RequestsMetricLabels.REQUEST_HANDLER]: ctx.requestHandlerName,`
	`57`	`+ [RequestsMetricLabels.STATUS_CODE]: ctx.response.status,`
	`58`	`+ }`
`56`	`59`	`)`
`57`	`60`	`}`
`58`	`61`
`@@ -72,6 +75,7 @@ export const addOtelRequestMetricsMiddleware = () => {`
`72`	`75`	`hrToMillisFloat(process.hrtime(start)),`
`73`	`76`	`{`
`74`	`77`	`[RequestsMetricLabels.REQUEST_HANDLER]: ctx.requestHandlerName,`
	`78`	`+ [RequestsMetricLabels.STATUS_CODE]: ctx.response.status,`
`75`	`79`	`}`
`76`	`80`	`)`
`77`	`81`