test: remove legacy facts

Author: TheMeier

spec/acceptance/rvm_system_spec.rb

@@ -5,9 +5,9 @@
 # rubocop:disable RSpec/MultipleMemoizedHelpers
 describe 'rvm' do
   # host variables
-  let(:osfamily) { fact('osfamily') }
-  let(:osname) { fact('operatingsystem') }
-  let(:osversion) { fact('operatingsystemrelease') }
+  let(:osfamily) { fact('os.family') }
+  let(:osname) { fact('os.name') }
+  let(:osversion) { fact('os.release.major') }
 
   # rvm config
   let(:rvm_path) { '/usr/local/rvm/' }
@@ -70,7 +70,7 @@
   # baseline manifest
   let(:manifest) do
     <<-EOS
-      if $::osfamily == 'RedHat' {
+      if $facts['os']['familiy'] == 'RedHat' {
         class { 'epel':
           before => Class['rvm'],
         }

spec/classes/dependencies_spec.rb

@@ -11,7 +11,7 @@
 
       it { is_expected.to compile.with_all_deps }
 
-      case os_facts[:osfamily]
+      case os_facts[:os]['family']
       when 'RedHat'
         it { is_expected.to contain_package('which') }
         it { is_expected.to contain_package('gcc') }

spec/classes/system_spec.rb

@@ -8,7 +8,6 @@
     {
       rvm_version: '1.10.0',
       root_home: '/root',
-      osfamily: 'Debian',
       os: {
         family: 'Debian'
       }

spec/defines/system_user_spec.rb

@@ -16,7 +16,7 @@
       it { is_expected.to contain_user(username) }
       it { is_expected.to contain_group(group) }
 
-      case os_facts[:osfamily]
+      case os_facts[:os]['family']
       when 'FreeBSD'
         it { is_expected.to contain_exec("rvm-system-user-#{username}").with_command("/usr/sbin/pw groupmod #{group} -m #{username}") }
       when 'Darwin'