plugin_conf_dir_mode too strict for /usr/lib/python2.7/site-packages/

[yorickps]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: puppet-agent-5.5.3-1.el7.x86_64
• Ruby: ruby-2.0.0.648-34.el7_6.x86_64
• Distribution: CentOS 7.6.1810
• Module version: 10.1.0

How to reproduce (e.g Puppet code you use)

Run puppet agent

What are you seeing

The module sets the permissions to 750 for /usr/lib/python2.7/site-packages/ breaking a lot of tools that end users can use on a shared system and that need to be executable from the aforementioned directory.

The module sets the mode via $plugin_conf_dir_mode, which is by default set to 750 for all plugin directories.

What behaviour did you expect instead

Do not touch the permissions for /usr/lib/python2.7/site-packages/

[traylenator]

I think generally just because collectd module is configured to use a directory it should not change the permissions of a directory.

It's the job of the thing deploying modules to set permissions if appropriate.