Add FixedSizedList to Arbitrary DType implementation#6925
Merged
robert3005 merged 3 commits intodevelopfrom Mar 12, 2026
Merged
Add FixedSizedList to Arbitrary DType implementation#6925robert3005 merged 3 commits intodevelopfrom
robert3005 merged 3 commits intodevelopfrom
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Contributor
|
oh we disabled it because the arrow conversion is broken, don't actually know if they fixed it yet? Ah my method is now on the latest version so we should be good if we change the arrow conversion: https://arrow.apache.org/rust/arrow/array/struct.FixedSizeListArray.html#method.try_new_with_length |
Contributor
Author
|
oh, glad you remembered this one, this was defintely sad bug to find |
Contributor
Author
|
Ok, updated to use new arrow method |
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though we implemented all the arbitrary generation logic for FixedSizedList
arrays we didn't enable them in the fuzzer, i.e. added them to DType generation
logic
Signed-off-by: Robert Kruszewski github@robertk.io