Skip to content

skip[ci]: use prebuild images for some runs#6923

Merged
joseph-isaacs merged 16 commits intodevelopfrom
ji/pre-build-x86
Mar 13, 2026
Merged

skip[ci]: use prebuild images for some runs#6923
joseph-isaacs merged 16 commits intodevelopfrom
ji/pre-build-x86

Conversation

@joseph-isaacs
Copy link
Contributor

@joseph-isaacs joseph-isaacs commented Mar 12, 2026

Uses a pre-build CI image for some of the CI runs. I will monitor for a week and then move over everything.

runs:

  • windows
  • Rust lint
  • Rust arm64

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2026

Merging this PR will not alter performance

✅ 1009 untouched benchmarks
⏩ 1515 skipped benchmarks1


Comparing ji/pre-build-x86 (901a58b) with develop (0b981a8)

Open in CodSpeed

Footnotes

  1. 1515 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@joseph-isaacs joseph-isaacs changed the title fix more prebuild Mar 12, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
The ubuntu24-full-x64 image in the private runs-on config already
resolves to the custom vortex-ci-x64-* AMI, so no need for a
separate -pre image name.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Switch lint to ubuntu24-full-x64-pre and windows to
windows25-full-x64-pre. Revert local runs-on.yml to just
extend private config.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
The mozilla-actions/sccache-action conflicts with the sccache
already on the pre-built image, causing a version mismatch error
in the post-action stats step.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Pool overrides the image setting. Switch to runner= so the
image=windows25-full-x64-pre override is respected.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs changed the title more prebuild skip[ci]: use prebuild images for some runs Mar 13, 2026
@joseph-isaacs joseph-isaacs marked this pull request as ready for review March 13, 2026 13:12
@joseph-isaacs joseph-isaacs added the changelog/skip Do not list PR in the changelog label Mar 13, 2026
@joseph-isaacs joseph-isaacs requested a review from AdamGS March 13, 2026 13:12
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) March 13, 2026 13:12
VS Build Tools, Python, Rust, nextest, and sccache are all baked
into the vortex-ci-windows-x64 AMI. Use setup-prebuild for both
windows and arm64.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Rust is installed to $USERPROFILE\.cargo\bin on the AMI but
not on the runner PATH by default.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
The runner runs as 'runner' user but Rust was installed as
Administrator during AMI build.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit 2e9470f into develop Mar 13, 2026
92 of 96 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/pre-build-x86 branch March 13, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants