-
-
Notifications
You must be signed in to change notification settings - Fork 268
Expand file tree
/
Copy pathuse-cache-callable.test.ts
More file actions
503 lines (439 loc) · 19.9 KB
/
Copy pathuse-cache-callable.test.ts
File metadata and controls
503 lines (439 loc) · 19.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
import { expect, test, type Locator, type Page } from '@playwright/test'
import { type Fixture, useFixture } from './fixture'
import { expectNoPageError, testNoJs, waitForHydration } from './helper'
test.describe('dev', () => {
const f = useFixture({ root: 'examples/use-cache-callable', mode: 'dev' })
defineTests(f)
})
test.describe('build', () => {
const f = useFixture({ root: 'examples/use-cache-callable', mode: 'build' })
defineTests(f)
})
function defineTests(f: Fixture) {
test('inline directive', async ({ page }) => {
using _errors = expectNoPageError(page)
await page.goto(f.url())
await waitForHydration(page)
await page
.getByRole('link', { name: 'Inline directive', exact: true })
.click()
await expect(page).toHaveURL(f.url('/inline-directive'))
const example = page.getByTestId('inline-directive')
const submissionCount = example.getByTestId('submission-count')
const executionCount = example.getByTestId('execution-count')
const result = example.getByTestId('result')
const argument = example.getByRole('textbox', { name: 'Cache key' })
await page.getByRole('button', { name: 'Reset' }).click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('0')
await expect(result).toHaveText('not called')
// The callable is submitted every time, but the cached implementation runs once per argument.
// alpha (cache miss)
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('captured + alpha')
// alpha (cache hit)
await submit(page, example)
await expect(submissionCount).toHaveText('2')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('captured + alpha')
// beta (cache miss)
await argument.fill('beta')
await submit(page, example)
await expect(submissionCount).toHaveText('3')
await expect(executionCount).toHaveText('2')
await expect(result).toHaveText('captured + beta')
})
test('inline directive cache miss after hydrated reload', async ({
page,
}) => {
using _errors = expectNoPageError(page)
await page.goto(f.url('/inline-directive'))
await waitForHydration(page)
const example = page.getByTestId('inline-directive')
const submissionCount = example.getByTestId('submission-count')
const executionCount = example.getByTestId('execution-count')
const result = example.getByTestId('result')
await page.getByRole('button', { name: 'Reset' }).click()
await expect(executionCount).toHaveText('0')
// A fresh SSR form has new encrypted `$ACTION_*` fields, so the FormData cache
// argument changes. A framework can avoid this with custom form handling that
// passes only application fields, as the protected-captures example does.
// https://github.com/hi-ogawa/reproductions/tree/main/next-use-cache-form-reload
// alpha (cache miss)
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('captured + alpha')
// alpha after reload (cache miss)
await page.reload()
await waitForHydration(page)
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('2')
await expect(result).toHaveText('captured + alpha')
})
testNoJs('inline directive progressive enhancement', async ({ page }) => {
await page.goto(f.url('/inline-directive'))
const example = page.getByTestId('inline-directive')
const submissionCount = example.getByTestId('submission-count')
const executionCount = example.getByTestId('execution-count')
const result = example.getByTestId('result')
const argument = example.getByRole('textbox', { name: 'Cache key' })
const call = example.getByRole('button', { name: 'Call cached function' })
await page.getByRole('button', { name: 'Reset' }).click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('0')
await expect(result).toHaveText('not called')
// Native form submissions call the same cached function without hydration.
// alpha (cache miss)
await argument.fill('alpha')
await call.click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('captured + alpha')
// alpha (cache hit)
await argument.fill('alpha')
await call.click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('captured + alpha')
// beta (cache miss)
await argument.fill('beta')
await call.click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('2')
await expect(result).toHaveText('captured + beta')
})
test('file directive from server', async ({ page }) => {
using _errors = expectNoPageError(page)
await page.goto(f.url('/file-directive-from-server'))
await waitForHydration(page)
const example = page.getByTestId('file-directive-from-server')
const submissionCount = example.getByTestId('submission-count')
const executionCount = example.getByTestId('execution-count')
const ordinaryExports = example.getByTestId('ordinary-exports')
const result = example.getByTestId('result')
const argument = example.getByRole('textbox', { name: 'Cache key' })
await page.getByRole('button', { name: 'Reset' }).click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('0')
await expect(ordinaryExports).toHaveText('object: array')
await expect(result).toHaveText('not called')
// The wrapped export is passed from a Server Component to a Client Component.
// alpha (cache miss)
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('server import + alpha')
// alpha (cache hit)
await submit(page, example)
await expect(submissionCount).toHaveText('2')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('server import + alpha')
// beta (cache miss)
await argument.fill('beta')
await submit(page, example)
await expect(submissionCount).toHaveText('3')
await expect(executionCount).toHaveText('2')
await expect(result).toHaveText('server import + beta')
})
test('file directive cache hit after hydrated reload', async ({ page }) => {
using _errors = expectNoPageError(page)
await page.goto(f.url('/file-directive-from-server'))
await waitForHydration(page)
const example = page.getByTestId('file-directive-from-server')
const submissionCount = example.getByTestId('submission-count')
const executionCount = example.getByTestId('execution-count')
const result = example.getByTestId('result')
await page.getByRole('button', { name: 'Reset' }).click()
await expect(executionCount).toHaveText('0')
// Reloading and hydrating a fresh SSR form preserves the cache hit for the same argument.
// alpha (cache miss)
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('server import + alpha')
// alpha after reload (cache hit)
await page.reload()
await waitForHydration(page)
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('server import + alpha')
})
testNoJs(
'file directive from server progressive enhancement',
async ({ page }) => {
await page.goto(f.url('/file-directive-from-server'))
const example = page.getByTestId('file-directive-from-server')
const submissionCount = example.getByTestId('submission-count')
const executionCount = example.getByTestId('execution-count')
const result = example.getByTestId('result')
const argument = example.getByRole('textbox', { name: 'Cache key' })
const call = example.getByRole('button', { name: 'Call cached function' })
await page.getByRole('button', { name: 'Reset' }).click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('0')
await expect(result).toHaveText('not called')
// The wrapped export remains callable through native form submissions.
// alpha (cache miss)
await argument.fill('alpha')
await call.click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('server import + alpha')
// alpha (cache hit)
await argument.fill('alpha')
await call.click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('server import + alpha')
// beta (cache miss)
await argument.fill('beta')
await call.click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('2')
await expect(result).toHaveText('server import + beta')
},
)
test('file directive from client', async ({ page }) => {
using _errors = expectNoPageError(page)
await page.goto(f.url('/file-directive-from-client'))
await waitForHydration(page)
const example = page.getByTestId('file-directive-from-client')
const submissionCount = example.getByTestId('submission-count')
const executionCount = example.getByTestId('execution-count')
const result = example.getByTestId('result')
const argument = example.getByRole('textbox', { name: 'Cache key' })
await page.getByRole('button', { name: 'Reset' }).click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('0')
await expect(result).toHaveText('not called')
// The generated client proxy calls the wrapped export.
// alpha (cache miss)
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('client import + alpha')
// alpha (cache hit)
await submit(page, example)
await expect(submissionCount).toHaveText('2')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('client import + alpha')
// beta (cache miss)
await argument.fill('beta')
await submit(page, example)
await expect(submissionCount).toHaveText('3')
await expect(executionCount).toHaveText('2')
await expect(result).toHaveText('client import + beta')
})
testNoJs(
'file directive from client progressive enhancement',
async ({ page }) => {
await page.goto(f.url('/file-directive-from-client'))
const example = page.getByTestId('file-directive-from-client')
const submissionCount = example.getByTestId('submission-count')
const executionCount = example.getByTestId('execution-count')
const result = example.getByTestId('result')
const argument = example.getByRole('textbox', { name: 'Cache key' })
const call = example.getByRole('button', { name: 'Call cached function' })
await page.getByRole('button', { name: 'Reset' }).click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('0')
await expect(result).toHaveText('not called')
// The generated client proxy remains callable through native form submissions.
// alpha (cache miss)
await argument.fill('alpha')
await call.click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('client import + alpha')
// alpha (cache hit)
await argument.fill('alpha')
await call.click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('client import + alpha')
// beta (cache miss)
await argument.fill('beta')
await call.click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('2')
await expect(result).toHaveText('client import + beta')
},
)
test('file directive extra arguments', async ({ page }) => {
using _errors = expectNoPageError(page)
await page.goto(f.url('/file-directive-extra-arguments'))
await waitForHydration(page)
const example = page.getByTestId('file-directive-extra-arguments')
const submissionCount = example.getByTestId('submission-count')
const executionCount = example.getByTestId('execution-count')
const result = example.getByTestId('result')
const argument = example.getByRole('textbox', { name: 'Ignored argument' })
await page.getByRole('button', { name: 'Reset' }).click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('0')
await expect(result).toHaveText('not called')
// React supplies FormData to the zero-parameter function, but it does not
// participate in the cache key or invocation.
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('arguments: 0')
await argument.fill('beta')
await submit(page, example)
await expect(submissionCount).toHaveText('2')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('arguments: 0')
})
test('inline directive extra arguments', async ({ page }) => {
using _errors = expectNoPageError(page)
await page.goto(f.url('/inline-directive-extra-arguments'))
await waitForHydration(page)
const example = page.getByTestId('inline-directive-extra-arguments')
const submissionCount = example.getByTestId('submission-count')
const executionCount = example.getByTestId('execution-count')
const result = example.getByTestId('result')
const argument = example.getByRole('textbox', {
name: 'Undeclared argument',
})
await page.getByRole('button', { name: 'Reset' }).click()
await expect(submissionCount).toHaveText('0')
await expect(executionCount).toHaveText('0')
await expect(result).toHaveText('not called')
// React supplies FormData to the zero-parameter function, but it does not
// participate in the cache key or invocation.
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('arguments: 0')
await argument.fill('beta')
await submit(page, example)
await expect(submissionCount).toHaveText('2')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('arguments: 0')
})
for (const testCase of [
{
route: 'use-cache-in-use-server-from-client',
defaultExecutions: 2,
overrideExecutions: 1,
},
{
route: 'use-cache-in-use-server-from-server',
defaultExecutions: 2,
overrideExecutions: 1,
},
{
route: 'use-server-in-use-cache-from-client',
defaultExecutions: 1,
overrideExecutions: 2,
},
{
route: 'use-server-in-use-cache-from-server',
defaultExecutions: 1,
overrideExecutions: 2,
},
]) {
test(testCase.route.replaceAll('-', ' '), async ({ page }) => {
using _errors = expectNoPageError(page)
await page.goto(f.url('/' + testCase.route))
await waitForHydration(page)
const example = page.getByTestId(testCase.route)
const defaultExecutions = example.getByTestId('default-executions')
const overrideExecutions = example.getByTestId('override-executions')
await example.getByRole('button', { name: 'Reset' }).click()
await expect(defaultExecutions).toHaveText('0')
await expect(overrideExecutions).toHaveText('0')
await callAction(page, example, 'Call default action')
await callAction(page, example, 'Call default action')
await expect(defaultExecutions).toHaveText(
String(testCase.defaultExecutions),
)
// An inline directive overrides the behavior inherited from the file.
await callAction(page, example, 'Call override action')
await callAction(page, example, 'Call override action')
await expect(overrideExecutions).toHaveText(
String(testCase.overrideExecutions),
)
})
}
test('protected captures', async ({ page }) => {
// verify captured value is encoded and thus doesn't appear in raw response
const rscResponse = await page.request.get(
f.url('/protected-captures_.rsc'),
)
expect(rscResponse.ok()).toBe(true)
expect(await rscResponse.text()).not.toContain('capture-secret')
using _errors = expectNoPageError(page)
await page.goto(f.url())
await waitForHydration(page)
await page.getByRole('link', { name: 'Protected captures' }).click()
await expect(page).toHaveURL(f.url('/protected-captures'))
const example = page.getByTestId('protected-captures')
const submissionCount = example.getByTestId('submission-count')
const capture = page.getByTestId('capture')
const executionCount = example.getByTestId('execution-count')
const result = example.getByTestId('result')
await page.getByRole('button', { name: 'Reset' }).click()
await expect(submissionCount).toHaveText('0')
await expect(capture).toHaveText('first')
await expect(executionCount).toHaveText('0')
await expect(result).toHaveText('not called')
// submit with "first" capture and "alpha" argument
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('first + alpha')
// A fresh render and ciphertext for the same logical capture still hits.
await page.reload()
await waitForHydration(page)
await submit(page, example)
await expect(submissionCount).toHaveText('1')
await expect(executionCount).toHaveText('1')
await expect(result).toHaveText('first + alpha')
// The same invocation with a different decoded capture is a cache miss.
await page.getByRole('button', { name: 'Second capture' }).click()
await expect(capture).toHaveText('second')
await submit(page, example)
await expect(submissionCount).toHaveText('2')
await expect(executionCount).toHaveText('2')
await expect(result).toHaveText('second + alpha')
await page.getByRole('button', { name: 'First capture' }).click()
await expect(capture).toHaveText('first')
await submit(page, example)
await expect(submissionCount).toHaveText('3')
await expect(executionCount).toHaveText('2')
// A cache hit skips the implementation, so its previous display side effect remains.
await expect(result).toHaveText('second + alpha')
})
}
async function callAction(page: Page, example: Locator, name: string) {
const [response] = await Promise.all([
page.waitForResponse(
(response) =>
response.request().method() === 'POST' &&
response.url().includes('_.rsc'),
),
example.getByRole('button', { name }).click(),
])
expect(response.ok()).toBe(true)
}
async function submit(page: Page, form: Locator) {
// `submissionCount` updates immediately on the client, while a cache hit leaves
// the server-rendered execution count and result unchanged. Those assertions do
// not prove that the server action and subsequent render have completed, so wait
// for the action response before proceeding.
const [response] = await Promise.all([
page.waitForResponse(
(response) =>
response.request().method() === 'POST' &&
response.url().includes('_.rsc'),
),
form.getByRole('button', { name: 'Call cached function' }).click(),
])
expect(response.ok()).toBe(true)
}