chore: add oxlint (#126)

Author: sapphi-red

.github/workflows/ci.yml

@@ -34,3 +34,6 @@ jobs:
 
       - name: Check formatting
         run: pnpm format --check
+
+      - name: Check linting
+        run: pnpm oxlint

.oxlintrc.json

@@ -0,0 +1,28 @@
+{
+  "$schema": "./node_modules/oxlint/configuration_schema.json",
+  "plugins": ["eslint", "node", "oxc"],
+  "categories": {
+    "correctness": "error",
+    "suspicious": "error"
+  },
+  "env": {
+    "builtin": true,
+    "es2018": true,
+    "node": true,
+    "commonjs": true
+  },
+  "rules": {
+    "no-case-declarations": "error",
+    "no-empty": "error",
+    "no-fallthrough": "error",
+    "no-prototype-builtins": "error",
+    "no-redeclare": "error",
+    "no-regex-spaces": "error",
+    "no-unused-vars": [
+      "error",
+      {
+        "caughtErrorsIgnorePattern": "^ignore"
+      }
+    ]
+  }
+}

eslint.config.mjs

@@ -3,7 +3,7 @@
   "scripts": {
     "test": "pnpm -r test",
     "release": "bumpp",
-    "lint": "eslint packages --fix",
+    "lint": "oxlint --fix",
     "format": "oxfmt"
   },
   "devDependencies": {
@@ -13,14 +13,15 @@
     "globals": "^16.3.0",
     "lint-staged": "^6.1.1",
     "oxfmt": "^0.52.0",
+    "oxlint": "^1.67.0",
     "yorkie": "^1.0.3"
   },
   "lint-staged": {
     "*": [
       "oxfmt --no-error-on-unmatched-pattern"
     ],
     "*.js": [
-      "eslint --fix",
+      "oxlint --fix",
       "git add"
     ]
   },

package.json

@@ -21,7 +21,7 @@ module.exports = function getArgumentsForPosition(editor, fileName, lineNumber,
       return [`+call cursor(${lineNumber}, ${columnNumber})`, fileName]
     case 'joe':
     case 'gvim':
-      return ['+' + `${lineNumber}`, fileName]
+      return [`+${lineNumber}`, fileName]
     case 'emacs':
     case 'emacsclient':
       return [`+${lineNumber}:${columnNumber}`, fileName]

packages/launch-editor/get-args.js

@@ -60,7 +60,7 @@ function parseFile(file) {
   }
 }
 
-let _childProcess = null
+let currentChildProcess = null
 
 function launchEditor(file, specifiedEditor, onErrorCallback) {
   const parsed = parseFile(file)
@@ -105,11 +105,11 @@ function launchEditor(file, specifiedEditor, onErrorCallback) {
     args.push(fileName)
   }
 
-  if (_childProcess && isTerminalEditor(editor)) {
+  if (currentChildProcess && isTerminalEditor(editor)) {
     // There's an existing editor process already and it's attached
     // to the terminal, so go kill it. Otherwise two separate editor
     // instances attach to the stdin/stdout which gets confusing.
-    _childProcess.kill('SIGKILL')
+    currentChildProcess.kill('SIGKILL')
   }
 
   if (process.platform === 'win32') {
@@ -156,22 +156,22 @@ function launchEditor(file, specifiedEditor, onErrorCallback) {
     }
     const launchCommand = [editor, ...args.map(escapeCmdArgs)].map(doubleQuoteIfNeeded).join(' ')
 
-    _childProcess = childProcess.exec(launchCommand, {
+    currentChildProcess = childProcess.exec(launchCommand, {
       stdio: 'inherit',
       shell: true,
     })
   } else {
-    _childProcess = childProcess.spawn(editor, args, { stdio: 'inherit' })
+    currentChildProcess = childProcess.spawn(editor, args, { stdio: 'inherit' })
   }
-  _childProcess.on('exit', function (errorCode) {
-    _childProcess = null
+  currentChildProcess.on('exit', function (errorCode) {
+    currentChildProcess = null
 
     if (errorCode) {
       onErrorCallback(fileName, '(code ' + errorCode + ')')
     }
   })
 
-  _childProcess.on('error', function (error) {
+  currentChildProcess.on('error', function (error) {
     let { code, message } = error
     if ('ENOENT' === code) {
       message = `${message} ('${editor}' command does not exist in 'PATH')`