chore(lint): update golangci-lint (radius-project#11020)

# Description

This pull request updates the golangci-lint tool to version 2.8.0 across
the development environment and CI workflow, and makes minor
improvements to the linter configuration for clarity and compatibility.

## Type of change

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

## Contributor checklist
Please verify that the PR meets the following requirements, where
applicable:

<!--
This checklist uses "TaskRadio" comments to make certain options
mutually exclusive.
See:
https://github.com/mheap/require-checklist-action?tab=readme-ov-file#radio-groups
For details on how this works and why it's required.
-->

- An overview of proposed schema changes is included in a linked GitHub
issue.
    - [ ] Yes <!-- TaskRadio schema -->
    - [x] Not applicable <!-- TaskRadio schema -->
- A design document PR is created in the [design-notes
repository](https://github.com/radius-project/design-notes/), if new
APIs are being introduced.
    - [ ] Yes <!-- TaskRadio design-pr -->
    - [x] Not applicable <!-- TaskRadio design-pr -->
- The design document has been reviewed and approved by Radius
maintainers/approvers.
    - [ ] Yes <!-- TaskRadio design-review -->
    - [x] Not applicable <!-- TaskRadio design-review -->
- A PR for the [samples
repository](https://github.com/radius-project/samples) is created, if
existing samples are affected by the changes in this PR.
    - [ ] Yes <!-- TaskRadio samples-pr -->
    - [x] Not applicable <!-- TaskRadio samples-pr -->
- A PR for the [documentation
repository](https://github.com/radius-project/docs) is created, if the
changes in this PR affect the documentation or any user facing updates
are made.
    - [ ] Yes <!-- TaskRadio docs-pr -->
    - [x] Not applicable <!-- TaskRadio docs-pr -->
- A PR for the [recipes
repository](https://github.com/radius-project/recipes) is created, if
existing recipes are affected by the changes in this PR.
    - [ ] Yes <!-- TaskRadio recipes-pr -->
    - [x] Not applicable <!-- TaskRadio recipes-pr -->

---------

Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>

Author: DariuszPorowski

.devcontainer/post-create.sh

@@ -6,18 +6,18 @@ set -e
 npm install -g @typespec/compiler
 
 # Adding workspace as safe directory to avoid permission issues
-git config --global --add safe.directory /workspaces/radius 
+git config --global --add safe.directory /workspaces/radius
 
 # Install the binary form of golangci-lint, as recommended
 # https://golangci-lint.run/welcome/install/#local-installation
-curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b "$(go env GOPATH)/bin" v2.5.0
+curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b "$(go env GOPATH)/bin" v2.8.0
 
 # Other go tools
-go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.17.0 
+go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.17.0
 go install go.uber.org/mock/mockgen@v0.4.0
 
 # Prerequisites for Code Generation, see https://github.com/radius-project/radius/tree/main/docs/contributing/contributing-code/contributing-code-prerequisites#code-generation
-cd typespec || exit 
-npm ci 
+cd typespec || exit
+npm ci
 npm install -g autorest@3.7.2
 npm install -g oav@4.0.2

.github/workflows/lint.yaml

@@ -111,7 +111,7 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
         with:
-          version: v2.5.0
+          version: v2.8.0
           args: --timeout=10m
           skip-cache: true
           install-mode: binary

.golangci.yml

@@ -1,10 +1,12 @@
+# yaml-language-server: $schema=https://www.schemastore.org/golangci-lint.json
 # see https://golangci-lint.run/usage/configuration/ for documentation
+---
 version: "2"
 linters:
-  # Only enable forbidigo explicitly. The v2 defaults (errcheck, gosimple, govet, 
+  # Only enable forbidigo explicitly. The v2 defaults (errcheck, gosimple, govet,
   # ineffassign, staticcheck, unused) are implicitly enabled to match v1 behavior.
   enable:
-  - forbidigo
+    - forbidigo
   settings:
     # Configure default linters to match v1 behavior (less strict)
     errcheck:
@@ -31,7 +33,7 @@ linters:
         - os.RemoveAll
         - os.Setenv
         - os.Unsetenv
-    
+
     govet:
       # Only run a subset of analyzers to match v1 behavior
       enable:
@@ -57,15 +59,32 @@ linters:
         - unreachable
         - unsafeptr
         - unusedresult
-    
+
     staticcheck:
       # Use the same checks as v1 (disable newer style/quickfix checks)
       # QF rules are "quickfix" suggestions that weren't in v1
       # ST rules are style checks that are often too pedantic
-      checks: ["all", 
-        "-ST1000", "-ST1003", "-ST1005", "-ST1016", "-ST1019", "-ST1020", "-ST1021", "-ST1022", "-ST1023",
-        "-QF1001", "-QF1003", "-QF1004", "-QF1007", "-QF1008", "-QF1011", "-QF1012"]
-    
+      checks:
+        [
+          "all",
+          "-ST1000",
+          "-ST1003",
+          "-ST1005",
+          "-ST1016",
+          "-ST1019",
+          "-ST1020",
+          "-ST1021",
+          "-ST1022",
+          "-ST1023",
+          "-QF1001",
+          "-QF1003",
+          "-QF1004",
+          "-QF1007",
+          "-QF1008",
+          "-QF1011",
+          "-QF1012",
+        ]
+
     forbidigo:
       # Forbid the following identifiers (list of regexp)
       #
@@ -75,6 +94,6 @@ linters:
         # These APIs exit the process. These are OK to use in the main() function,
         # and not ANYWHERE else.
         - pattern: 'os\.Exit'
-          msg: '# Do not use except for inside main(). Suppress this message with //nolint:forbidigo at the end of the line if it is correct.'
+          msg: "# Do not use except for inside main(). Suppress this message with //nolint:forbidigo at the end of the line if it is correct."
         - pattern: 'log\.Fatal(f|ln)?'
-          msg: '# Do not use except for inside main(). Suppress this message with //nolint:forbidigo at the end of the line if it is correct.'
+          msg: "# Do not use except for inside main(). Suppress this message with //nolint:forbidigo at the end of the line if it is correct."