Skip to content

[Bug] peerDependencies for deck/luma/loaders should pin to minor version (rather than major) #273

@keller-mark

Description

@keller-mark

Module

  • deck.gl-community/arrow-layers
  • deck.gl-community/bing-maps
  • deck.gl-community/editable-layers
  • deck.gl-community/experimental
  • deck.gl-community/graph-layers
  • deck.gl-community/layers
  • deck.gl-community/react
  • deck.gl-community/react-graph-layer

Description

When trying to use @deck.gl-community/editable-layers with a particular minor version of deck.gl, my package manager always tries to override it to use a newer minor version, because the peer dependencies pin to the major versions (e.g., "@deck.gl/core": "^9.1.12" rather than the minor version which can be done with the tilde "@deck.gl/core": "~9.1.12")

"@deck.gl/core": "^9.1.12",

This causes issues, as minor versions of deck.gl and luma.gl can introduce breaking changes to the internals needed for such custom layers.

Expected Behavior

Pin to minor versions of deck/lumaGL packages using tilde version syntax.

Steps to Reproduce

Try to install a past version such as "@deck.gl-community/editable-layers": "9.0.3" with its matching DeckGL version

See https://unpkg.com/@deck.gl-community/[email protected]/package.json , this version specified "@deck.gl/core": "^9.0.12" in its package.json . But installing today, my package manager forces me to install @deck.gl/core v9.1.x which is incompatible.

Environment

  • Framework version: v9.x
  • Browser: N/A
  • OS: macOS

Logs

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions