From f5af932e9e5406b7baf5d04f5a33fcec670f0c8c Mon Sep 17 00:00:00 2001 From: Ethan Rodkin Date: Wed, 26 Feb 2025 15:04:52 -0500 Subject: [PATCH 1/2] update workflow --- .github/workflows/update_protos.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/update_protos.yml b/.github/workflows/update_protos.yml index cdb069a7c..5dbfbc48f 100644 --- a/.github/workflows/update_protos.yml +++ b/.github/workflows/update_protos.yml @@ -21,6 +21,9 @@ jobs: steps: - name: Checkout Code uses: actions/checkout@v4 + # CR erodkin: this part is probably good though + with: + token: ${{ secrets.REPO_READ_TOKEN }} - name: Update API if: ${{ !inputs.api_version }} # called from outside @@ -42,6 +45,9 @@ jobs: title: Automated Protos Update body: This is an auto-generated PR to update proto definitions. Check the commits to see which repos and commits are responsible for the changes team-reviewers: sdk-netcode + # CR erodkin: not sure this part is actually necessary + env: + GITHUB_TOKEN: ${{ secrets.REPO_READ_TOKEN }} - name: Notify slack of failure uses: slackapi/slack-github-action@v1.24.0 From 2a05d1d6d258f88c95f73d77a3a3ee1e9d733912 Mon Sep 17 00:00:00 2001 From: Ethan Rodkin Date: Fri, 7 Mar 2025 14:19:27 -0500 Subject: [PATCH 2/2] cleanup --- .github/workflows/update_protos.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/update_protos.yml b/.github/workflows/update_protos.yml index 5dbfbc48f..da67c0026 100644 --- a/.github/workflows/update_protos.yml +++ b/.github/workflows/update_protos.yml @@ -21,7 +21,6 @@ jobs: steps: - name: Checkout Code uses: actions/checkout@v4 - # CR erodkin: this part is probably good though with: token: ${{ secrets.REPO_READ_TOKEN }} @@ -45,9 +44,6 @@ jobs: title: Automated Protos Update body: This is an auto-generated PR to update proto definitions. Check the commits to see which repos and commits are responsible for the changes team-reviewers: sdk-netcode - # CR erodkin: not sure this part is actually necessary - env: - GITHUB_TOKEN: ${{ secrets.REPO_READ_TOKEN }} - name: Notify slack of failure uses: slackapi/slack-github-action@v1.24.0