From 62ecd17b9abcb17137a5c04c689cc5b58b72b85b Mon Sep 17 00:00:00 2001 From: Ethan Rodkin Date: Tue, 10 Jun 2025 11:05:12 -0400 Subject: [PATCH 1/6] add generics and button to codesamples --- examples/apis.json | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/examples/apis.json b/examples/apis.json index ab4498030..2dabedcb3 100644 --- a/examples/apis.json +++ b/examples/apis.json @@ -9,6 +9,18 @@ "args": ["\"16\""], "packagePath": "viam.components" }, + "button": { + "func": "push", + "packagePath": "viam.components", + "commented": true + }, + "genericcomponent": { + "func": "do_command", + "args": ["{}"], + "packagePath": "viam.components", + "commented": true, + "importName": "GenericComponent" + }, "camera": { "func": "get_image", "packagePath": "viam.components" @@ -82,6 +94,13 @@ "packagePath": "viam.services", "importName": "MLModelClient" }, + "genericservice": { + "func": "do_command", + "args": ["{}"], + "packagePath": "viam.services", + "commented": true, + "importName": "GenericService" + }, "slam": { "func": "get_point_cloud_map", "packagePath": "viam.services", From fd34c14d21692abd2aedcbd7aa4b3c7d0e8e7cc7 Mon Sep 17 00:00:00 2001 From: Ethan Rodkin Date: Tue, 10 Jun 2025 11:07:21 -0400 Subject: [PATCH 2/6] button does not return --- examples/apis.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/apis.json b/examples/apis.json index 2dabedcb3..1f388b8e3 100644 --- a/examples/apis.json +++ b/examples/apis.json @@ -12,7 +12,8 @@ "button": { "func": "push", "packagePath": "viam.components", - "commented": true + "commented": true, + "hasReturn", false }, "genericcomponent": { "func": "do_command", From 69bc0eec74df4063bbc1fb7cba061656c3a11629 Mon Sep 17 00:00:00 2001 From: Ethan Rodkin Date: Tue, 10 Jun 2025 11:11:25 -0400 Subject: [PATCH 3/6] fix typo --- examples/apis.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/apis.json b/examples/apis.json index 1f388b8e3..59b2824f3 100644 --- a/examples/apis.json +++ b/examples/apis.json @@ -13,7 +13,7 @@ "func": "push", "packagePath": "viam.components", "commented": true, - "hasReturn", false + "hasReturn": false }, "genericcomponent": { "func": "do_command", From 86d1a06301660d12054986fe9d5d7e408ba920af Mon Sep 17 00:00:00 2001 From: Ethan Rodkin Date: Wed, 11 Jun 2025 14:46:09 -0400 Subject: [PATCH 4/6] test --- examples/apis.json | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/examples/apis.json b/examples/apis.json index 59b2824f3..8134ba1e3 100644 --- a/examples/apis.json +++ b/examples/apis.json @@ -10,17 +10,16 @@ "packagePath": "viam.components" }, "button": { - "func": "push", - "packagePath": "viam.components", - "commented": true, - "hasReturn": false + "func": "push", + "packagePath": "viam.components", + "commented": true, + "hasReturn": false }, "genericcomponent": { - "func": "do_command", - "args": ["{}"], - "packagePath": "viam.components", - "commented": true, - "importName": "GenericComponent" + "func": "do_command", + "args": ["{}"], + "packagePath": "viam.components", + "commented": true }, "camera": { "func": "get_image", @@ -96,11 +95,11 @@ "importName": "MLModelClient" }, "genericservice": { - "func": "do_command", - "args": ["{}"], - "packagePath": "viam.services", - "commented": true, - "importName": "GenericService" + "func": "do_command", + "args": ["{}"], + "packagePath": "viam.services", + "commented": true, + "importName": "Generic" }, "slam": { "func": "get_point_cloud_map", From 48f338ef77bf9ff40a3881b18bb53299f8d674be Mon Sep 17 00:00:00 2001 From: Ethan Rodkin Date: Wed, 11 Jun 2025 14:47:26 -0400 Subject: [PATCH 5/6] remove importname from generic service --- examples/apis.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/apis.json b/examples/apis.json index 8134ba1e3..bd8f88119 100644 --- a/examples/apis.json +++ b/examples/apis.json @@ -98,8 +98,7 @@ "func": "do_command", "args": ["{}"], "packagePath": "viam.services", - "commented": true, - "importName": "Generic" + "commented": true }, "slam": { "func": "get_point_cloud_map", From b99bdadd59ff3320b76421331d9787118e6735ae Mon Sep 17 00:00:00 2001 From: Ethan Rodkin Date: Wed, 11 Jun 2025 14:51:39 -0400 Subject: [PATCH 6/6] re-add importname --- examples/apis.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/apis.json b/examples/apis.json index bd8f88119..e3a1ff921 100644 --- a/examples/apis.json +++ b/examples/apis.json @@ -19,7 +19,8 @@ "func": "do_command", "args": ["{}"], "packagePath": "viam.components", - "commented": true + "commented": true, + "importName": "GenericComponent" }, "camera": { "func": "get_image", @@ -98,7 +99,8 @@ "func": "do_command", "args": ["{}"], "packagePath": "viam.services", - "commented": true + "commented": true, + "importName": "GenericService" }, "slam": { "func": "get_point_cloud_map",